Commit 4e5dcf36 authored by Matt Selsky's avatar Matt Selsky Committed by Tiago Mello

Bug 571740: Add support for getsatisfaction for the See Also field

r=timello, a=LpSolit
parent 8837967f
...@@ -133,8 +133,7 @@ sub class_for { ...@@ -133,8 +133,7 @@ sub class_for {
if $subclass->should_handle($uri); if $subclass->should_handle($uri);
} }
ThrowUserError('bug_url_invalid', { url => $value, ThrowUserError('bug_url_invalid', { url => $value });
reason => 'show_bug' });
} }
sub _check_class { sub _check_class {
......
...@@ -13,6 +13,7 @@ use constant MORE_SUB_CLASSES => qw( ...@@ -13,6 +13,7 @@ use constant MORE_SUB_CLASSES => qw(
Bugzilla::Extension::MoreBugUrl::ReviewBoard Bugzilla::Extension::MoreBugUrl::ReviewBoard
Bugzilla::Extension::MoreBugUrl::Rietveld Bugzilla::Extension::MoreBugUrl::Rietveld
Bugzilla::Extension::MoreBugUrl::RT Bugzilla::Extension::MoreBugUrl::RT
Bugzilla::Extension::MoreBugUrl::GetSatisfaction
); );
# We need to update bug_see_also table because both # We need to update bug_see_also table because both
......
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
#
# This Source Code Form is "Incompatible With Secondary Licenses", as
# defined by the Mozilla Public License, v. 2.0.
package Bugzilla::Extension::MoreBugUrl::GetSatisfaction;
use strict;
use base qw(Bugzilla::BugUrl);
###############################
#### Methods ####
###############################
sub should_handle {
my ($class, $uri) = @_;
# GetSatisfaction URLs only have one form:
# http(s)://getsatisfaction.com/PROJECT_NAME/topics/TOPIC_NAME
return ($uri->authority =~ /^getsatisfaction.com$/i
and $uri->path =~ m|^/[^/]+/topics/[^/]+$|) ? 1 : 0;
}
sub _check_value {
my ($class, $uri) = @_;
$uri = $class->SUPER::_check_value($uri);
# GetSatisfaction HTTP URLs redirect to HTTPS, so just use the HTTPS
# scheme.
$uri->scheme('https');
return $uri;
}
1;
...@@ -9,3 +9,4 @@ ...@@ -9,3 +9,4 @@
<li>A Review Board review request.</li> <li>A Review Board review request.</li>
<li>An issue in a Rietveld installation.</li> <li>An issue in a Rietveld installation.</li>
<li>A ticket in an RT installation.</li> <li>A ticket in an RT installation.</li>
<li>A topic on getsatisfaction.com.</li>
...@@ -242,7 +242,9 @@ ...@@ -242,7 +242,9 @@
URLs must start with "http" or "https". URLs must start with "http" or "https".
[% ELSIF reason == 'path_only' %] [% ELSIF reason == 'path_only' %]
You must specify a full URL. You must specify a full URL.
[% ELSIF reason == 'show_bug' %] [% ELSIF reason == 'id' %]
There is no valid [% terms.bug %] id in that URL.
[% ELSE %]
[%+ field_descs.see_also FILTER html %] URLs should point to one of: [%+ field_descs.see_also FILTER html %] URLs should point to one of:
<ul> <ul>
<li><code>show_bug.cgi</code> in a [% terms.Bugzilla %] <li><code>show_bug.cgi</code> in a [% terms.Bugzilla %]
...@@ -257,8 +259,6 @@ ...@@ -257,8 +259,6 @@
<li>An issue on github.com.</li> <li>An issue on github.com.</li>
[% Hook.process('bug_url_invalid_tracker') %] [% Hook.process('bug_url_invalid_tracker') %]
</ul> </ul>
[% ELSIF reason == 'id' %]
There is no valid [% terms.bug %] id in that URL.
[% END %] [% END %]
[% ELSIF error == "bug_url_too_long" %] [% ELSIF error == "bug_url_too_long" %]
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment