Commit 4e635c06 authored by justdave%bugzilla.org's avatar justdave%bugzilla.org

Bug 238797: minor adjustment to javascript filters to prevent tags inserted in…

Bug 238797: minor adjustment to javascript filters to prevent tags inserted in product, component, and flag names from causing problems. r=gerv, a=justdave
parent 33a8d184
...@@ -229,7 +229,7 @@ sub create { ...@@ -229,7 +229,7 @@ sub create {
# and newlines/carriage returns escaped for use in JS strings. # and newlines/carriage returns escaped for use in JS strings.
js => sub { js => sub {
my ($var) = @_; my ($var) = @_;
$var =~ s/([\\\'\"])/\\$1/g; $var =~ s/([\\\'\"\/])/\\$1/g;
$var =~ s/\n/\\n/g; $var =~ s/\n/\\n/g;
$var =~ s/\r/\\r/g; $var =~ s/\r/\\r/g;
$var =~ s/\@/\\x40/g; # anti-spam for email addresses $var =~ s/\@/\\x40/g; # anti-spam for email addresses
......
...@@ -98,7 +98,7 @@ ...@@ -98,7 +98,7 @@
<td> <td>
<a href="editflagtypes.cgi?action=copy&amp;id=[% type.id %]">Copy</a> <a href="editflagtypes.cgi?action=copy&amp;id=[% type.id %]">Copy</a>
| <a href="editflagtypes.cgi?action=confirmdelete&amp;id=[% type.id %]" | <a href="editflagtypes.cgi?action=confirmdelete&amp;id=[% type.id %]"
onclick="return confirmDelete([% type.id %], '[% type.name FILTER js %]', onclick="return confirmDelete([% type.id %], '[% type.name FILTER js FILTER html %]',
[% type.flag_count %]);">Delete</a> [% type.flag_count %]);">Delete</a>
</td> </td>
</tr> </tr>
......
...@@ -97,7 +97,7 @@ ...@@ -97,7 +97,7 @@
[% terms.bug %] to [% terms.bug %] to
</label> </label>
<input name="assigned_to" size="32" <input name="assigned_to" size="32"
onchange="if ((this.value != '[% bug.assigned_to.email FILTER js %]') && onchange="if ((this.value != '[% bug.assigned_to.email FILTER js FILTER html %]') &&
(this.value != '')) { (this.value != '')) {
document.changeform.knob[[% knum %]].checked=true; document.changeform.knob[[% knum %]].checked=true;
}" }"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment