Bug 526189: Silently ignore any attempts to add an inactive group to a bug,…

Bug 526189: Silently ignore any attempts to add an inactive group to a bug, which fixes the fact that mandatory groups were being added to bugs when changing products, even if they were inactive (not used for bugs). Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit

Bug 526189: Silently ignore any attempts to add an inactive group to a bug,…
4ecad695 · mkanat%bugzilla.org · 4980d093 · 4ecad695
Commit 4ecad695 authored Nov 18, 2009 by mkanat%bugzilla.org
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 0 deletions

Bug.pm Bugzilla/Bug.pm +2 -0

No files found.
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -2285,6 +2285,8 @@ sub add_group {
    $group = new Bugzilla::Group($group) unless ref $group;
    return unless $group;

+    return if !$group->is_active or !$group->is_bug_group;
+
    # Make sure that bugs in this product can actually be restricted
    # to this group.
    grep($group->id == $_->id, @{$self->product_obj->groups_valid})