Bug 1032323: canonicalise_query() should omit parameters with empty values so…

Bug 1032323: canonicalise_query() should omit parameters with empty values so generated URLs are shorter r=glob,a=sgreen

Bug 1032323: canonicalise_query() should omit parameters with empty values so…
515a56de · Ed Morley · Byron Jones · 2f10cf7b · 515a56de
Commit 515a56de authored Jul 10, 2014 by Ed Morley Committed by Byron Jones Jul 10, 2014
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 2 deletions

CGI.pm Bugzilla/CGI.pm +5 -2

No files found.
--- a/Bugzilla/CGI.pm
+++ b/Bugzilla/CGI.pm
@@ -124,7 +124,8 @@ sub canonicalise_query {
        my $esc_key = url_quote($key);

        foreach my $value ($self->param($key)) {
-            if (defined($value)) {
+            # Omit params with an empty value
+            if (defined($value) && $value ne '') {
                my $esc_value = url_quote($value);

                push(@parameters, "$esc_key=$esc_value");
@@ -659,7 +660,9 @@ I<Bugzilla::CGI> also includes additional functions.

 =item C<canonicalise_query(@exclude)>

-This returns a sorted string of the parameters, suitable for use in a url.
+This returns a sorted string of the parameters whose values are non-empty,
+suitable for use in a url.
+
 Values in C<@exclude> are not included in the result.

 =item C<send_cookie>