Bug 76923 - Don't |use diagnostics| (its really expensive at startup time)

r=joel x2

Bug 76923 - Don't |use diagnostics| (its really expensive at startup time)
5b18c51f · bbaetz%student.usyd.edu.au · 2154f730 · 5b18c51f · 5b18c51f · 5b18c51f
Commit 5b18c51f authored Aug 26, 2002 by bbaetz%student.usyd.edu.au
65 changed files
--- a/Attachment.pm
+++ b/Attachment.pm
@@ -24,7 +24,6 @@
 # Module Initialization
 ############################################################################
-use diagnostics;
 use strict;
 package Attachment;

--- a/Bug.pm
+++ b/Bug.pm
@@ -21,7 +21,6 @@
 #                 Terry Weissman <terry@mozilla.org>
 #                 Chris Yeh      <cyeh@bluemartini.com>
-use diagnostics;
 use strict;
 use DBI;

--- a/Bugzilla/Attachment.pm
+++ b/Bugzilla/Attachment.pm
@@ -24,7 +24,6 @@
 # Module Initialization
 ############################################################################
-use diagnostics;
 use strict;
 package Attachment;

--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -21,7 +21,6 @@
 #                 Terry Weissman <terry@mozilla.org>
 #                 Chris Yeh      <cyeh@bluemartini.com>
-use diagnostics;
 use strict;
 use DBI;

--- a/Bugzilla/RelationSet.pm
+++ b/Bugzilla/RelationSet.pm
@@ -29,7 +29,6 @@
 # might involve turning this into a virtual base class, and having
 # UserSet and KeywordSet types that inherit from it.
-use diagnostics;
 use strict;
 # Everything that uses RelationSet should already have globals.pl loaded

--- a/Bugzilla/Search.pm
+++ b/Bugzilla/Search.pm
@@ -25,7 +25,6 @@
 #                 Myk Melez <myk@mozilla.org>
 #                 Michael Schindler <michael@compressconsult.com>
-use diagnostics;
 use strict;
 require "globals.pl";

--- a/Bugzilla/Token.pm
+++ b/Bugzilla/Token.pm
@@ -24,7 +24,6 @@
 ################################################################################
 # Make it harder for us to do dangerous things in Perl.
-use diagnostics;
 use strict;
 # Bundle the functions in this file together into the "Token" package.

--- a/Bugzilla/Util.pm
+++ b/Bugzilla/Util.pm
@@ -69,7 +69,6 @@ use base qw(Exporter);
                             trim);
 use strict;
-use diagnostics;
 =head1 FUNCTIONS

--- a/CGI.pl
+++ b/CGI.pl
@@ -27,7 +27,6 @@
 # Contains some global routines used throughout the CGI scripts of Bugzilla.
-use diagnostics;
 use strict;
 use lib ".";

--- a/RelationSet.pm
+++ b/RelationSet.pm
@@ -29,7 +29,6 @@
 # might involve turning this into a virtual base class, and having
 # UserSet and KeywordSet types that inherit from it.
-use diagnostics;
 use strict;
 # Everything that uses RelationSet should already have globals.pl loaded

--- a/Token.pm
+++ b/Token.pm
@@ -24,7 +24,6 @@
 ################################################################################
 # Make it harder for us to do dangerous things in Perl.
-use diagnostics;
 use strict;
 # Bundle the functions in this file together into the "Token" package.

--- a/attachment.cgi
+++ b/attachment.cgi
@@ -26,7 +26,6 @@
 ################################################################################
 # Make it harder for us to do dangerous things in Perl.
-use diagnostics;
 use strict;
 use lib qw(.);

--- a/bug_form.pl
+++ b/bug_form.pl
@@ -21,7 +21,6 @@
 #                 Dave Miller <justdave@syndicomm.com>
 #                 Vaskin Kissoyan <vkissoyan@yahoo.com>
-use diagnostics;
 use strict;
 use RelationSet;

--- a/buglist.cgi
+++ b/buglist.cgi
@@ -29,7 +29,6 @@
 ################################################################################
 # Make it harder for us to do dangerous things in Perl.
-use diagnostics;
 use strict;
 use lib qw(.);

--- a/checksetup.pl
+++ b/checksetup.pl
@@ -94,7 +94,6 @@
 # Global definitions
 ###########################################################################
-use diagnostics;
 use strict;
 # 12/17/00 justdave@syndicomm.com - removed declarations of the localconfig

--- a/colchange.cgi
+++ b/colchange.cgi
@@ -21,7 +21,6 @@
 # Contributor(s): Terry Weissman <terry@mozilla.org>
 #                 Gervase Markham <gerv@gerv.net>
-use diagnostics;
 use strict;
 use lib qw(.);

--- a/collectstats.pl
+++ b/collectstats.pl
@@ -26,7 +26,6 @@
 use AnyDBM_File;
-use diagnostics;
 use strict;
 use vars @::legal_product;

--- a/contrib/BugzillaEmail.pm
+++ b/contrib/BugzillaEmail.pm
@@ -29,7 +29,6 @@ push @INC, "../."; # this script now lives in contrib
 require "globals.pl";
-use diagnostics;
 use strict;
 my $EMAIL_TRANSFORM_NONE = "email_transform_none";

--- a/contrib/bug_email.pl
+++ b/contrib/bug_email.pl
@@ -37,7 +37,7 @@
 #
 # You need to work with bug_email.pl the MIME::Parser installed.
 # 
-# $Id: bug_email.pl,v 1.12 2002/08/17 14:19:57 bbaetz%student.usyd.edu.au Exp $
+# $Id: bug_email.pl,v 1.13 2002/08/26 06:17:21 bbaetz%student.usyd.edu.au Exp $
 ###############################################################
 # 02/12/2000 (SML)
@@ -66,7 +66,6 @@
 # - integrate some setup in the checksetup.pl script
 # - gpg signatures for security
-use diagnostics;
 use strict;
 use MIME::Parser;

--- a/contrib/bugzilla_email_append.pl
+++ b/contrib/bugzilla_email_append.pl
@@ -28,7 +28,6 @@
 # 1. better way to get the body text (I don't know what dump_entity() is 
 #   actually doing
-use diagnostics;
 use strict;
 use MIME::Parser;

--- a/contrib/mysqld-watcher.pl
+++ b/contrib/mysqld-watcher.pl
@@ -23,7 +23,6 @@
 # mysqld-watcher.pl - a script that watches the running instance of
 # mysqld and kills off any long-running SELECTs against the shadow_db
 # 
-use diagnostics;
 use strict;
 # some configurables: 

--- a/createaccount.cgi
+++ b/createaccount.cgi
@@ -24,7 +24,6 @@
 #                 Christopher Aillon <christopher@aillon.com>
 #                 Gervase Markham <gerv@gerv.net>
-use diagnostics;
 use strict;
 use lib qw(.);

--- a/defparams.pl
+++ b/defparams.pl
@@ -33,7 +33,6 @@
 # Only adding new parameters is done here.  Once the parameter exists, you 
 # must use %baseurl%/editparams.cgi from the web to edit the settings.
-use diagnostics;
 use strict;
 # Shut up misguided -w warnings about "used only once".  For some reason,

--- a/describecomponents.cgi
+++ b/describecomponents.cgi
@@ -27,7 +27,6 @@ use vars qw(
  $userid
 );
-use diagnostics;
 use strict;
 use lib qw(.);

--- a/describekeywords.cgi
+++ b/describekeywords.cgi
@@ -21,7 +21,6 @@
 # Contributor(s): Terry Weissman <terry@mozilla.org>
 # Contributor(s): Gervase Markham <gerv@gerv.net>
-use diagnostics;
 use strict;
 use lib ".";

--- a/doeditparams.cgi
+++ b/doeditparams.cgi
@@ -21,7 +21,6 @@
 # Contributor(s): Terry Weissman <terry@mozilla.org>
 #                 J. Paul Reed <preed@sigkill.com>
-use diagnostics;
 use strict;
 use lib qw(.);

--- a/duplicates.cgi
+++ b/duplicates.cgi
@@ -23,7 +23,6 @@
 # Generates mostfreq list from data collected by collectstats.pl.
-use diagnostics;
 use strict;
 use AnyDBM_File;

--- a/editattachstatuses.cgi
+++ b/editattachstatuses.cgi
@@ -26,7 +26,6 @@
 ################################################################################
 # Make it harder for us to do dangerous things in Perl.
-use diagnostics;
 use strict;
 use lib ".";

--- a/editcomponents.cgi
+++ b/editcomponents.cgi
@@ -25,7 +25,6 @@
 #
 # Holger Schurig <holgerschurig@nikocity.de>
-use diagnostics;
 use strict;
 use lib ".";

--- a/editgroups.cgi
+++ b/editgroups.cgi
@@ -23,7 +23,6 @@
 # Code derived from editowners.cgi and editusers.cgi
-use diagnostics;
 use strict;
 use lib ".";

--- a/editkeywords.cgi
+++ b/editkeywords.cgi
@@ -20,7 +20,6 @@
 #
 # Contributor(s): Terry Weissman <terry@mozilla.org>
-use diagnostics;
 use strict;
 use lib ".";

--- a/editmilestones.cgi
+++ b/editmilestones.cgi
@@ -13,7 +13,6 @@
 #
-use diagnostics;
 use strict;
 use lib ".";

--- a/editparams.cgi
+++ b/editparams.cgi
@@ -22,7 +22,6 @@
 #                 J. Paul Reed <preed@sigkill.com>
-use diagnostics;
 use strict;
 use lib ".";

--- a/editproducts.cgi
+++ b/editproducts.cgi
@@ -27,7 +27,6 @@
 #
 # Holger Schurig <holgerschurig@nikocity.de>
-use diagnostics;
 use strict;
 use lib ".";

--- a/editusers.cgi
+++ b/editusers.cgi
@@ -27,7 +27,6 @@
 #
 # Holger Schurig <holgerschurig@nikocity.de>
-use diagnostics;
 use strict;
 use lib ".";

--- a/editversions.cgi
+++ b/editversions.cgi
@@ -26,7 +26,6 @@
 #
 # Holger Schurig <holgerschurig@nikocity.de>
-use diagnostics;
 use strict;
 use lib ".";

--- a/enter_bug.cgi
+++ b/enter_bug.cgi
@@ -32,7 +32,6 @@
 #
 ##############################################################################
-use diagnostics;
 use strict;
 use lib qw(.);

--- a/globals.pl
+++ b/globals.pl
@@ -25,7 +25,6 @@
 # Contains some global variables and routines used throughout bugzilla.
-use diagnostics;
 use strict;
 use Bugzilla::Util;

--- a/importxml.pl
+++ b/importxml.pl
@@ -25,7 +25,6 @@
 # a new bug into bugzilla. Everything before the beginning <?xml line
 # is removed so you can pipe in email messages.
-use diagnostics;
 use strict;
 #####################################################################

--- a/index.cgi
+++ b/index.cgi
@@ -30,7 +30,6 @@ use vars qw{ %COOKIE };
 ###############################################################################
 # Make it harder for us to do dangerous things in Perl.
-use diagnostics;
 use strict;
 # Include the Bugzilla CGI and general utility library.

--- a/long_list.cgi
+++ b/long_list.cgi
@@ -21,7 +21,6 @@
 # Contributor(s): Terry Weissman <terry@mozilla.org>
 #                 Gervase Markham <gerv@gerv.net>
-use diagnostics;
 use strict;
 use lib qw(.);

--- a/move.pl
+++ b/move.pl
@@ -21,7 +21,6 @@
 # Contributor(s): Dawn Endico    <endico@mozilla.org>
 #                 Terry Weissman <terry@mozilla.org>
-use diagnostics;
 use strict;
 use lib qw(.);

--- a/page.cgi
+++ b/page.cgi
@@ -28,7 +28,6 @@
 # either case), numbers 0-9, the underscore "_" and the hyphen "-".
 ###############################################################################
-use diagnostics;
 use strict;
 use lib ".";

--- a/post_bug.cgi
+++ b/post_bug.cgi
@@ -23,7 +23,6 @@
 #                 Joe Robins <jmrobins@tgix.com>
 #                 Gervase Markham <gerv@gerv.net>
-use diagnostics;
 use strict;
 use lib qw(.);

--- a/process_bug.cgi
+++ b/process_bug.cgi
@@ -24,7 +24,6 @@
 #                 Christopher Aillon <christopher@aillon.com>
 #                 Myk Melez <myk@mozilla.org>
-use diagnostics;
 use strict;
 my $UserInEditGroupSet = -1;

--- a/processmail
+++ b/processmail
@@ -25,7 +25,6 @@
 #                 Jacob Steenhagen <jake@actex.net>
 #                 Matthew Tuck <matty@chariot.net.au>
-use diagnostics;
 use strict;
 use lib ".";

--- a/query.cgi
+++ b/query.cgi
@@ -23,7 +23,6 @@
 #                 Matthias Radestock <matthias@sorted.org>
 #                 Gervase Markham <gerv@gerv.net>
-use diagnostics;
 use strict;
 use lib ".";

--- a/queryhelp.cgi
+++ b/queryhelp.cgi
@@ -24,7 +24,6 @@
 use vars %::FORM;
-use diagnostics;
 use strict;
 use lib qw(.);

--- a/quips.cgi
+++ b/quips.cgi
@@ -22,7 +22,6 @@
 #                 Gervase Markham <gerv@gerv.net>
 #                 David Fallon <davef@tetsubo.com>
-use diagnostics;
 use strict;
 use vars qw(

--- a/relogin.cgi
+++ b/relogin.cgi
@@ -21,7 +21,6 @@
 # Contributor(s): Terry Weissman <terry@mozilla.org>
 #                 Gervase Markham <gerv@gerv.net>
-use diagnostics;
 use strict;
 use vars %::COOKIE;

--- a/reports.cgi
+++ b/reports.cgi
@@ -38,7 +38,6 @@
 # Myk Melez <myk@mozilla.org):
 #    Implemented form field validation and reorganized code.
-use diagnostics;
 use strict;
 use lib qw(.);

--- a/sanitycheck.cgi
+++ b/sanitycheck.cgi
@@ -21,7 +21,6 @@
 # Contributor(s): Terry Weissman <terry@mozilla.org>
 #                 Matthew Tuck <matty@chariot.net.au>
-use diagnostics;
 use strict;
 use lib qw(.);

--- a/show_activity.cgi
+++ b/show_activity.cgi
@@ -22,7 +22,6 @@
 #                 Myk Melez <myk@mozilla.org>
 #                 Gervase Markham <gerv@gerv.net>
-use diagnostics;
 use strict;
 use lib qw(.);

--- a/show_bug.cgi
+++ b/show_bug.cgi
@@ -20,7 +20,6 @@
 #
 # Contributor(s): Terry Weissman <terry@mozilla.org>
-use diagnostics;
 use strict;
 use lib qw(.);

--- a/showattachment.cgi
+++ b/showattachment.cgi
@@ -21,7 +21,6 @@
 # Contributor(s): Terry Weissman <terry@mozilla.org>
 #                 Jacob Steenhagen <jake@acutex.net>
-use diagnostics;
 use strict;
 use lib qw(.);

--- a/showdependencygraph.cgi
+++ b/showdependencygraph.cgi
@@ -21,7 +21,6 @@
 # Contributor(s): Terry Weissman <terry@mozilla.org>
 #                 Gervase Markham <gerv@gerv.net>
-use diagnostics;
 use strict;
 use lib qw(.);

--- a/showdependencytree.cgi
+++ b/showdependencytree.cgi
@@ -23,7 +23,6 @@
 #                 Christian Reis <kiko@async.com.br>
 #                 Myk Melez <myk@mozilla.org>
-use diagnostics;
 use strict;
 use lib qw(.);

--- a/sidebar.cgi
+++ b/sidebar.cgi
@@ -16,7 +16,6 @@
 # Contributor(s): Jacob Steenhagen <jake@acutex.net>
 use strict;
-use diagnostics;
 use lib ".";
 require "CGI.pl";

--- a/syncshadowdb
+++ b/syncshadowdb
@@ -21,7 +21,6 @@
 # Contributor(s): Terry Weissman <terry@mozilla.org>
 #                 David Gardiner <david.gardiner@unisa.edu.au>
-use diagnostics;
 use strict;
 require "globals.pl";

--- a/t/Support/Templates.pm
+++ b/t/Support/Templates.pm
@@ -23,7 +23,6 @@
 package Support::Templates;
-use diagnostics;
 use strict;
 use lib 't';

--- a/token.cgi
+++ b/token.cgi
@@ -25,7 +25,6 @@
 ############################################################################
 # Make it harder for us to do dangerous things in Perl.
-use diagnostics;
 use strict;
 use lib qw(.);

--- a/userprefs.cgi
+++ b/userprefs.cgi
@@ -20,7 +20,6 @@
 #                 Christopher Aillon <christopher@aillon.com>
 #                 Gervase Markham <gerv@gerv.net>
-use diagnostics;
 use strict;
 use lib qw(.);

--- a/votes.cgi
+++ b/votes.cgi
@@ -23,7 +23,6 @@
 #                 Christopher Aillon <christopher@aillon.com>
 #                 Gervase Markham <gerv@gerv.net>
-use diagnostics;
 use strict;
 use lib ".";

--- a/whineatnews.pl
+++ b/whineatnews.pl
@@ -26,7 +26,6 @@
 # assigned to them that has status NEW that has not been touched for
 # more than 7 days.
-use diagnostics;
 use strict;
 require "globals.pl";

--- a/xml.cgi
+++ b/xml.cgi
@@ -22,7 +22,6 @@
 #                 Terry Weissman <terry@mozilla.org>
 #                 Gervase Markham <gerv@gerv.net>
-use diagnostics;
 use strict;
 use lib qw(.);