Skip to content

bugzilla
bugzilla
Commit 5b260d69 authored by Max Kanat-Alexander's avatar Max Kanat-Alexander
Browse files
Options

Bug 561379: Upgrading from 3.4.4 to 3.6 would fails with ORA-01400,

because checksetup.pl was trying to run code that should never run on Oracle. r=mkanat, a=mkanat (module owner)
parent 0679b5e9
Hide whitespace changes
Inline Side-by-side
Showing with 7 additions and 0 deletions
Bugzilla/Install/DB.pm
View file @ 5b260d69
...@@ -1864,6 +1864,12 @@ sub _remove_spaces_and_commas_from_flagtypes { ...@@ -1864,6 +1864,12 @@ sub _remove_spaces_and_commas_from_flagtypes {
sub _setup_usebuggroups_backward_compatibility { sub _setup_usebuggroups_backward_compatibility {
my $dbh = Bugzilla->dbh; my $dbh = Bugzilla->dbh;
# Don't run this on newer Bugzillas. This is a reliable test because
# the longdescs table existed in 2.16 (which had usebuggroups)
# but not in 2.18, and this code happens between 2.16 and 2.18.
return if $dbh->bz_column_info('longdescs', 'already_wrapped');
# 2002-11-24 - bugreport@peshkin.net - bug 147275 # 2002-11-24 - bugreport@peshkin.net - bug 147275
# #
# If group_control_map is empty, backward-compatibility # If group_control_map is empty, backward-compatibility
...@@ -1871,6 +1877,7 @@ sub _setup_usebuggroups_backward_compatibility { ...@@ -1871,6 +1877,7 @@ sub _setup_usebuggroups_backward_compatibility {
my ($maps_exist) = $dbh->selectrow_array( my ($maps_exist) = $dbh->selectrow_array(
"SELECT DISTINCT 1 FROM group_control_map"); "SELECT DISTINCT 1 FROM group_control_map");
if (!$maps_exist) { if (!$maps_exist) {
print "Converting old usebuggroups controls...\n";
# Initially populate group_control_map. # Initially populate group_control_map.
# First, get all the existing products and their groups. # First, get all the existing products and their groups.
my $sth = $dbh->prepare("SELECT groups.id, products.id, groups.name, my $sth = $dbh->prepare("SELECT groups.id, products.id, groups.name,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment