Commit 5bbb0f10 authored by zach%zachlipton.com's avatar zach%zachlipton.com

Fix for bug 121735: Perl warning running checksetup.pl if a module has a

non-numeric version number. Patch sets checksetup.pl to use a string compare instead of a numeric one. Patch by Dave Miller. r1=Bradley Baetz and r2=Gerv
parent f87e6aed
......@@ -167,10 +167,10 @@ sub have_vers {
$vnum = ${"${pkg}::VERSION"} || ${"${pkg}::Version"} || 0;
$vnum = -1 if $@;
if ($vnum < 0) {
if ($vnum eq "-1") { # string compare just in case it's non-numeric
$vstr = "not found";
}
elsif ($vnum > 0) {
elsif (vers_cmp($vnum,"0") > -1) {
$vstr = "found v$vnum";
}
else {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment