Skip to content

bugzilla
bugzilla
Commit 5fcefed7 authored by lpsolit%gmail.com's avatar lpsolit%gmail.com
Browse files
Options

Bug 380756: Remove duplicates.xul (and all the code related to it) - Patch by…

Bug 380756: Remove duplicates.xul (and all the code related to it) - Patch by FrÃ:copyright:dÃ:copyright:ric Buclin <LpSolit@gmail.com> r=mkanat a=LpSolit
parent 6df961a5
Hide whitespace changes
Inline Side-by-side
Showing with 21 additions and 105 deletions
Bugzilla/Install/Filesystem.pm
View file @ 5fcefed7
...@@ -287,12 +287,8 @@ EOT ...@@ -287,12 +287,8 @@ EOT
# It's harmless if it isn't accessible... # It's harmless if it isn't accessible...
"$datadir/.htaccess" => { perms => $ws_readable, contents => <<EOT "$datadir/.htaccess" => { perms => $ws_readable, contents => <<EOT
# Nothing in this directory is retrievable unless overridden by an .htaccess # Nothing in this directory is retrievable unless overridden by an .htaccess
# in a subdirectory; the only exception is duplicates.rdf, which is used by # in a subdirectory.
# duplicates.xul and must be accessible from the web server
deny from all deny from all
<Files duplicates.rdf>
allow from all
</Files>
EOT EOT
...@@ -371,6 +367,11 @@ EOT ...@@ -371,6 +367,11 @@ EOT
unlink "$datadir/versioncache"; unlink "$datadir/versioncache";
} }
if (-e "$datadir/duplicates.rdf") {
print "Removing duplicates.rdf...\n";
unlink "$datadir/duplicates.rdf";
unlink "$datadir/duplicates-old.rdf";
}
} }
# A simple helper for creating "empty" CSS files. # A simple helper for creating "empty" CSS files.
......
collectstats.pl
View file @ 5fcefed7
...@@ -134,32 +134,6 @@ my $tend = time; ...@@ -134,32 +134,6 @@ my $tend = time;
CollectSeriesData(); CollectSeriesData();
{
local $ENV{'GATEWAY_INTERFACE'} = 'cmdline';
local $ENV{'REQUEST_METHOD'} = 'GET';
local $ENV{'QUERY_STRING'} = 'ctype=rdf';
my $perl = $^X;
trick_taint($perl);
# Generate a static RDF file containing the default view of the duplicates data.
open(CGI, "$perl -T duplicates.cgi |")
|| die "can't fork duplicates.cgi: $!";
open(RDF, ">$datadir/duplicates.tmp")
|| die "can't write to $datadir/duplicates.tmp: $!";
my $headers_done = 0;
while (<CGI>) {
print RDF if $headers_done;
$headers_done = 1 if $_ eq "\r\n";
}
close CGI;
close RDF;
}
if (-s "$datadir/duplicates.tmp") {
rename("$datadir/duplicates.rdf", "$datadir/duplicates-old.rdf");
rename("$datadir/duplicates.tmp", "$datadir/duplicates.rdf");
}
sub check_data_dir { sub check_data_dir {
my $dir = shift; my $dir = shift;
......
docs/en/xml/security.xml
View file @ 5fcefed7
<!-- <!DOCTYPE chapter PUBLIC "-//OASIS//DTD DocBook XML V4.1.2//EN"> --> <!-- <!DOCTYPE chapter PUBLIC "-//OASIS//DTD DocBook XML V4.1.2//EN"> -->
<!-- $Id: security.xml,v 1.15 2008/04/04 06:48:22 mozilla%colinogilvie.co.uk Exp $ --> <!-- $Id: security.xml,v 1.19 2008/05/21 00:01:04 lpsolit%gmail.com Exp $ -->
<chapter id="security"> <chapter id="security">
<title>Bugzilla Security</title> <title>Bugzilla Security</title>
...@@ -57,7 +57,7 @@ ...@@ -57,7 +57,7 @@
<note> <note>
<para>You will need to set the <option>webservergroup</option> option <para>You will need to set the <option>webservergroup</option> option
in <filename>localconfig</filename> to the group your webserver runs in <filename>localconfig</filename> to the group your web server runs
as. This will allow <filename>./checksetup.pl</filename> to set file as. This will allow <filename>./checksetup.pl</filename> to set file
permissions on Unix systems so that nothing is world-writable. permissions on Unix systems so that nothing is world-writable.
</para> </para>
...@@ -137,7 +137,7 @@ ...@@ -137,7 +137,7 @@
<section id="security-mysql-network"> <section id="security-mysql-network">
<title>Network Access</title> <title>Network Access</title>
<para>If MySQL and your webserver both run on the same machine and you <para>If MySQL and your web server both run on the same machine and you
have no other reason to access MySQL remotely, then you should disable have no other reason to access MySQL remotely, then you should disable
the network access. This, along with the suggestion in the network access. This, along with the suggestion in
<xref linkend="security-os-ports"/>, will help protect your system from <xref linkend="security-os-ports"/>, will help protect your system from
...@@ -171,20 +171,19 @@ skip-networking ...@@ -171,20 +171,19 @@ skip-networking
<section id="security-webserver"> <section id="security-webserver">
<title>Webserver</title> <title>Web server</title>
<section id="security-webserver-access"> <section id="security-webserver-access">
<title>Disabling Remote Access to Bugzilla Configuration Files</title> <title>Disabling Remote Access to Bugzilla Configuration Files</title>
<para>There are many files that are placed in the Bugzilla directory <para>
area that should not be accessable from the web. Because of the way There are many files that are placed in the Bugzilla directory
Bugzilla is currently layed out, the list of what should and should not area that should not be accessible from the web server. Because of the way
be accessible is rather complicated. A new installation method is Bugzilla is currently layed out, the list of what should and should not
currently in the works which should solve this by allowing files that be accessible is rather complicated. A quick way is to run
shouldn't be accessible from the web to be placed in a directory outside <filename>testserver.pl</filename> to check if your web server serves
the webroot. See Bugzilla files as expected. If not, you may want to follow the few
<ulink url="http://bugzilla.mozilla.org/show_bug.cgi?id=44659">bug 44659</ulink> steps below.
for more information.
</para> </para>
<tip> <tip>
...@@ -216,13 +215,6 @@ skip-networking ...@@ -216,13 +215,6 @@ skip-networking
<listitem> <listitem>
<para>Block everything</para> <para>Block everything</para>
</listitem> </listitem>
<listitem>
<para>But allow:
<simplelist type="inline">
<member><filename>duplicates.rdf</filename></member>
</simplelist>
</para>
</listitem>
</itemizedlist> </itemizedlist>
</listitem> </listitem>
...@@ -296,52 +288,21 @@ skip-networking ...@@ -296,52 +288,21 @@ skip-networking
properly blocked. Of particular interest is the localconfig file which properly blocked. Of particular interest is the localconfig file which
contains your database password. Also, be aware that many editors contains your database password. Also, be aware that many editors
create temporary and backup files in the working directory and that create temporary and backup files in the working directory and that
those should also not be accessable. For more information, see those should also not be accessible. For more information, see
<ulink url="http://bugzilla.mozilla.org/show_bug.cgi?id=186383">bug 186383</ulink> <ulink url="http://bugzilla.mozilla.org/show_bug.cgi?id=186383">bug 186383</ulink>
or or
<ulink url="http://online.securityfocus.com/bid/6501">Bugtraq ID 6501</ulink>. <ulink url="http://online.securityfocus.com/bid/6501">Bugtraq ID 6501</ulink>.
To test, simply point your web browser at the file; for example, to To test, simply run <filename>testserver.pl</filename>, as said above.
test mozilla.org's installation, we'd try to access
<ulink url="http://bugzilla.mozilla.org/localconfig"/>. You should get
a <quote><errorcode>403</errorcode> <errorname>Forbidden</errorname></quote>
error.
</para> </para>
<tip> <tip>
<para>Be sure to check <xref linkend="http"/> for instructions <para>Be sure to check <xref linkend="http"/> for instructions
specific to the webserver you use. specific to the web server you use.
</para> </para>
</tip> </tip>
</section> </section>
<section id="security-webserver-mod-throttle">
<title>Using <filename>mod_throttle</filename> to Prevent a DOS</title>
<note>
<para>This section only applies to people who have chosen the Apache
webserver. It may be possible to do similar things with other
webservers. Consult the documentation that came with your webserver
to find out.
</para>
</note>
<para>It is possible for a user, by mistake or on purpose, to access
the database many times in a row which can result in very slow access
speeds for other users (effectively, a
<glossterm linkend="gloss-dos">DOS</glossterm> attack). If your
Bugzilla installation is experiencing this problem, you may install
the Apache module <filename>mod_throttle</filename> which can limit
connections by IP address. You may download this module at
<ulink url="http://www.snert.com/Software/mod_throttle/"/>.
Follow the instructions to install into your Apache install.
The command you need is
<command>ThrottleClientIP</command>. See the
<ulink url="http://www.snert.com/Software/mod_throttle/">documentation</ulink>
for more information.</para>
</section>
</section> </section>
......
duplicates.cgi
View file @ 5fcefed7
...@@ -37,19 +37,6 @@ use Bugzilla::Search; ...@@ -37,19 +37,6 @@ use Bugzilla::Search;
use Bugzilla::Product; use Bugzilla::Product;
my $cgi = Bugzilla->cgi; my $cgi = Bugzilla->cgi;
# Go directly to the XUL version of the duplicates report (duplicates.xul)
# if the user specified ctype=xul. Adds params if they exist, and directs
# the user to a signed copy of the script in duplicates.jar if it exists.
if (defined $cgi->param('ctype') && $cgi->param('ctype') eq "xul") {
my $params = CanonicaliseParams($cgi->query_string(), ["format", "ctype"]);
my $url = (-e "duplicates.jar" ? "duplicates.jar!/" : "") .
"duplicates.xul" . ($params ? "?$params" : "") . "\n\n";
print $cgi->redirect($url);
exit;
}
my $template = Bugzilla->template; my $template = Bugzilla->template;
my $vars = {}; my $vars = {};
......
template/en/default/filterexceptions.pl
View file @ 5fcefed7
...@@ -148,13 +148,6 @@ ...@@ -148,13 +148,6 @@
'cumulate', 'cumulate',
], ],
'reports/duplicates.rdf.tmpl' => [
'template_version',
'bug.id',
'bug.count',
'bug.delta',
],
'reports/chart.html.tmpl' => [ 'reports/chart.html.tmpl' => [
'width', 'width',
'height', 'height',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment