Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
bugzilla
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
etersoft
bugzilla
Commits
646aa223
Commit
646aa223
authored
Sep 26, 2013
by
Sunil Joshi
Committed by
Simon Green
Sep 26, 2013
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Bug 714523 - editversions.cgi should use ->set_all
r=simon, a=simon
parent
2fe00715
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
7 deletions
+9
-7
Version.pm
Bugzilla/Version.pm
+5
-5
editversions.cgi
editversions.cgi
+4
-2
No files found.
Bugzilla/Version.pm
View file @
646aa223
...
...
@@ -169,8 +169,8 @@ sub product {
# Validators
################################
sub
set_
name
{
$_
[
0
]
->
set
(
'value'
,
$_
[
1
]);
}
sub
set_is
_
active
{
$_
[
0
]
->
set
(
'isactive'
,
$_
[
1
]);
}
sub
set_
value
{
$_
[
0
]
->
set
(
'value'
,
$_
[
1
]);
}
sub
set_isactive
{
$_
[
0
]
->
set
(
'isactive'
,
$_
[
1
]);
}
sub
_check_value
{
my
(
$invocant
,
$name
,
undef
,
$params
)
=
@_
;
...
...
@@ -219,7 +219,7 @@ Bugzilla::Version - Bugzilla product version class.
my $version = Bugzilla::Version->create(
{ value => $name, product => $product_obj });
$version->set_
nam
e($new_name);
$version->set_
valu
e($new_name);
$version->update();
$version->remove_from_db;
...
...
@@ -255,9 +255,9 @@ below.
=item DEFAULT_VERSION
=item set_is
_
active
=item set_isactive
=item set_
nam
e
=item set_
valu
e
=item product_id
...
...
editversions.cgi
View file @
646aa223
...
...
@@ -188,8 +188,10 @@ if ($action eq 'update') {
$dbh
->
bz_start_transaction
();
$version
->
set_name
(
$version_name
);
$version
->
set_is_active
(
$isactive
);
$version
->
set_all
({
value
=>
$version_name
,
isactive
=>
$isactive
});
my
$changes
=
$version
->
update
();
$dbh
->
bz_commit_transaction
();
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment