Commit 649a3891 authored by Matt Selsky's avatar Matt Selsky Committed by Gervase Markham

Bug 317021 - improve description of bz_canusewhine* parameters. r=gerv.

parent 977de764
...@@ -135,11 +135,13 @@ use constant SYSTEM_GROUPS => ( ...@@ -135,11 +135,13 @@ use constant SYSTEM_GROUPS => (
}, },
{ {
name => 'bz_canusewhineatothers', name => 'bz_canusewhineatothers',
description => 'Can configure whine reports for other users', description => 'Can configure queries and schedules for periodic'
. ' reports to be run and sent via email to other users and groups',
}, },
{ {
name => 'bz_canusewhines', name => 'bz_canusewhines',
description => 'User can configure whine reports for self', description => 'Can configure queries and schedules for periodic'
. ' reports to be run and sent via email to themselves',
# inherited_by means that users in the groups listed below are # inherited_by means that users in the groups listed below are
# automatically members of bz_canusewhines. # automatically members of bz_canusewhines.
inherited_by => ['editbugs', 'bz_canusewhineatothers'], inherited_by => ['editbugs', 'bz_canusewhineatothers'],
...@@ -217,8 +219,8 @@ sub update_system_groups { ...@@ -217,8 +219,8 @@ sub update_system_groups {
# Create most of the system groups # Create most of the system groups
foreach my $definition (SYSTEM_GROUPS) { foreach my $definition (SYSTEM_GROUPS) {
my $exists = new Bugzilla::Group({ name => $definition->{name} }); my $group = new Bugzilla::Group({ name => $definition->{name} });
if (!$exists) { if (!$group) {
$definition->{isbuggroup} = 0; $definition->{isbuggroup} = 0;
$definition->{silently} = !$editbugs_exists; $definition->{silently} = !$editbugs_exists;
my $inherited_by = delete $definition->{inherited_by}; my $inherited_by = delete $definition->{inherited_by};
...@@ -234,6 +236,10 @@ sub update_system_groups { ...@@ -234,6 +236,10 @@ sub update_system_groups {
} }
} }
} }
elsif ($group->description ne $definition->{description}) {
$group->set_description($definition->{description});
$group->update();
}
} }
$dbh->bz_commit_transaction(); $dbh->bz_commit_transaction();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment