Bug 818890: Bugzilla doesn't obey the "Comment required on status transition"…

Bug 818890: Bugzilla doesn't obey the "Comment required on status transition" for {Start}-> transition (for new bugs) r/a=LpSolit

Bug 818890: Bugzilla doesn't obey the "Comment required on status transition"…
64e21e0b · Alexander Tereschenko · Frédéric Buclin · db3413be · 64e21e0b
Commit 64e21e0b authored Dec 17, 2012 by Alexander Tereschenko Committed by Frédéric Buclin Dec 17, 2012
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 3 deletions

Bug.pm Bugzilla/Bug.pm +4 -3

No files found.
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -1323,11 +1323,12 @@ sub _check_bug_status {
    }

    # Check if a comment is required for this change.
-    if ($new_status->comment_required_on_change_from($old_status) && !$comment)
+    if ($new_status->comment_required_on_change_from($old_status)
+        && !$comment->{'thetext'})
    {
        ThrowUserError('comment_required',
-          { old => $old_status->name, new => $new_status->name,
-            field => 'bug_status' });
+          { old => $old_status ? $old_status->name : undef,
+            new => $new_status->name, field => 'bug_status' });
    }
    
    if (ref $invocant