Skip to content

bugzilla
bugzilla
Commit 6930e2af authored by mkanat%kerio.com's avatar mkanat%kerio.com
Browse files
Options

Bug 322771: PostgreSQL incorrectly detects that some summaries have control…

Bug 322771: PostgreSQL incorrectly detects that some summaries have control characters when they don't Patch By Frederic Buclin <LpSolit@gmail.com> r=mkanat, a=justdave
parent bdd1e6e3
Hide whitespace changes
Inline Side-by-side
Showing with 12 additions and 7 deletions
checksetup.pl
View file @ 6930e2af
......@@ -4245,17 +4245,22 @@ $dbh->bz_alter_column('logincookies', 'cookie',
my $controlchar_bugs =
$dbh->selectall_arrayref("SELECT short_desc, bug_id FROM bugs WHERE " .
$dbh->sql_regexp('short_desc', "'[[:cntrl:]]'"));
if (@$controlchar_bugs)
if (scalar(@$controlchar_bugs))
{
print 'Cleaning control characters from bug summaries...';
my $msg = 'Cleaning control characters from bug summaries...';
my $found = 0;
foreach (@$controlchar_bugs) {
my ($short_desc, $bug_id) = @$_;
print " $bug_id...";
$short_desc = clean_text($short_desc);
$dbh->do("UPDATE bugs SET short_desc = ? WHERE bug_id = ?",
undef, $short_desc, $bug_id);
my $clean_short_desc = clean_text($short_desc);
if ($clean_short_desc ne $short_desc) {
print $msg if !$found;
$found = 1;
print " $bug_id...";
$dbh->do("UPDATE bugs SET short_desc = ? WHERE bug_id = ?",
undef, $clean_short_desc, $bug_id);
}
}
print " done.\n";
print " done.\n" if $found;
}
# If you had to change the --TABLE-- definition in any way, then add your
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment