fix for 37684 and 42609: trying to deal with malformed url's in the URL field

during bug entry. instead of trying to be really intelligent over what a valid url field is, or doing any kind of complicated regexping and forcing http:// on everyone, what we do instead is pre-seed enter_bug.cgi bug_file_loc with http:// in the text field. if that is all there is in the field when we are in post_bug.cgi, then the value gets set to null (no URL entered into the new bug form). this allows for you to enter in any valid url that you want, but also make it obvious that http:// should be there for http:// urls at bug entry time

fix for 37684 and 42609: trying to deal with malformed url's in the URL field
6fc3ee11 · cyeh%bluemartini.com · 321412db · 6fc3ee11 · 6fc3ee11
Commit 6fc3ee11 authored Aug 31, 2000 by cyeh%bluemartini.com
Hide whitespace changes
Inline Side-by-side

Showing with 16 additions and 2 deletions

enter_bug.cgi enter_bug.cgi +1 -1

post_bug.cgi post_bug.cgi +15 -1

No files found.
--- a/enter_bug.cgi
+++ b/enter_bug.cgi
@@ -384,7 +384,7 @@ print "
  <TR>
    <TD ALIGN=RIGHT><B>URL:</B>
    <TD COLSPAN=5>
-      <INPUT NAME=bug_file_loc SIZE=60 value=\"" .
+      <INPUT NAME=bug_file_loc SIZE=60 value=\"http://" .
    value_quote(formvalue('bug_file_loc')) .
    "\"></TD>
  </TR>

--- a/post_bug.cgi
+++ b/post_bug.cgi
@@ -178,7 +178,21 @@ VALUES (
 ";

 foreach my $field (@used_fields) {
-    $query .= SqlQuote($::FORM{$field}) . ",\n";
+# fix for 42609. if there is a http:// only in bug_file_loc, strip
+# it out and send an empty value. 
+    if ($field eq 'bug_file_loc') {
+       if ($::FORM{$field} eq 'http://') {
+           $::FORM{$field} = "";
+           $query .= SqlQuote($::FORM{$field}) . ",\n";
+           next;
+       } 
+       else {
+          $query .= SqlQuote($::FORM{$field}) . ",\n";
+       }
+    }
+    else {
+       $query .= SqlQuote($::FORM{$field}) . ",\n";
+    }
 }

 my $comment = $::FORM{'comment'};