Bug 95799: sanitycheck.cgi should do email checks using…

Bug 95799: sanitycheck.cgi should do email checks using Util::validate_email_syntax() - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=justdave

Bug 95799: sanitycheck.cgi should do email checks using…
7a3c2eb8 · lpsolit%gmail.com · 3b2f0ca8 · 7a3c2eb8
Commit 7a3c2eb8 authored Nov 22, 2005 by lpsolit%gmail.com
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 4 deletions

sanitycheck.cgi sanitycheck.cgi +3 -4

No files found.
--- a/sanitycheck.cgi
+++ b/sanitycheck.cgi
@@ -29,6 +29,7 @@ use lib qw(.);

 require "globals.pl";
 use Bugzilla::Constants;
+use Bugzilla::Util;
 use Bugzilla::User;

 ###########################################################################
@@ -500,13 +501,11 @@ DoubleCrossCheck("milestones", "product_id", "value",
 
 Status("Checking profile logins");

-my $emailregexp = Param("emailregexp");
 SendSQL("SELECT userid, login_name FROM profiles");

 while (my ($id,$email) = (FetchSQLData())) {
-    unless ($email =~ m/$emailregexp/) {
-        Alert "Bad profile email address, id=$id,  &lt;$email&gt;."
-    }
+    validate_email_syntax($email)
+      || Alert "Bad profile email address, id=$id,  &lt;$email&gt;.";
 }

 ###########################################################################