Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
bugzilla
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
etersoft
bugzilla
Commits
7beba3d3
Commit
7beba3d3
authored
May 25, 2010
by
Kent Rogers
Committed by
Max Kanat-Alexander
May 25, 2010
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Bug 271913: Don't force the user to comment when adding Hours Worked
r=mkanat, a=mkanat
parent
2fee0823
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
6 deletions
+3
-6
Bug.pm
Bugzilla/Bug.pm
+2
-6
comments.html.tmpl
template/en/default/bug/comments.html.tmpl
+1
-0
No files found.
Bugzilla/Bug.pm
View file @
7beba3d3
...
...
@@ -2407,11 +2407,7 @@ sub add_comment {
$comment
=
$self
->
_check_comment
(
$comment
);
$params
||=
{};
if
(
exists
$params
->
{
work_time
})
{
$params
->
{
work_time
}
=
$self
->
_check_work_time
(
$params
->
{
work_time
});
ThrowUserError
(
'comment_required'
)
if
$comment
eq
''
&&
$params
->
{
work_time
}
!=
0
;
}
$params
->
{
work_time
}
=
$self
->
_check_work_time
(
$params
->
{
work_time
});
if
(
exists
$params
->
{
type
})
{
$params
->
{
type
}
=
$self
->
_check_comment_type
(
$params
->
{
type
});
}
...
...
@@ -2421,7 +2417,7 @@ sub add_comment {
}
# XXX We really should check extra_data, too.
if
(
$comment
eq
''
&&
!
(
$params
->
{
type
}
||
$params
->
{
work_time
}
))
{
if
(
$comment
eq
''
&&
!
(
$params
->
{
type
}
||
abs
(
$params
->
{
work_time
})
))
{
return
;
}
...
...
template/en/default/bug/comments.html.tmpl
View file @
7beba3d3
...
...
@@ -89,6 +89,7 @@
[% BLOCK a_comment %]
[% RETURN IF comment.is_private AND ! user.is_insider %]
[% RETURN IF comment.body == '' AND comment.work_time != 0 AND !user.is_timetracker %]
<div id="c[% count %]" class="bz_comment[% " bz_private" IF comment.is_private %]
[% " bz_comment_hilite" IF marks.$count %]
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment