Commit 7d01cb03 authored by lpsolit%gmail.com's avatar lpsolit%gmail.com

Bug 476889: importxml.pl crashes when importing bugs (Date::Parse::strptime()…

Bug 476889: importxml.pl crashes when importing bugs (Date::Parse::strptime() leave seconds undefined in some cases) - Patch by Fré©ric Buclin <LpSolit@gmail.com> r=ghendricks a=LpSolit
parent 95777645
......@@ -444,6 +444,9 @@ sub format_time {
my @time = strptime($date);
if (scalar @time) {
# Fix a bug in strptime() where seconds can be undefined in some cases.
$time[0] ||= 0;
# strptime() counts years from 1900, and months from 0 (January).
# We have to fix both values.
my $dt = DateTime->new({year => 1900 + $time[5],
......
......@@ -567,7 +567,7 @@ sub process_bug {
my $comments;
$comments .= "\n\n--- Bug imported by $exporter_login ";
$comments .= format_time(localtime(time()), '%Y-%m-%d %H:%M %Z') . " ";
$comments .= format_time(scalar localtime(time()), '%Y-%m-%d %R %Z') . " ";
$comments .= " ---\n\n";
$comments .= "This bug was previously known as _bug_ $bug_fields{'bug_id'} at ";
$comments .= $urlbase . "show_bug.cgi?id=" . $bug_fields{'bug_id'} . "\n";
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment