Commit 7d2b61ef authored by Frédéric Buclin's avatar Frédéric Buclin

Some more cleanup in xt/

parent 86fb87f1
...@@ -63,3 +63,5 @@ sub call { ...@@ -63,3 +63,5 @@ sub call {
die 'error ' . $res->{code} . ': ' . $res->{message} . "\n"; die 'error ' . $res->{code} . ': ' . $res->{message} . "\n";
} }
} }
1;
...@@ -126,7 +126,10 @@ sub _get { ...@@ -126,7 +126,10 @@ sub _get {
1; 1;
package QA::RPC::JSONRPC::ReturnObject; package QA::RPC::JSONRPC::ReturnObject;
use 5.14.0;
use strict; use strict;
use warnings;
BEGIN { BEGIN {
if (eval { require JSON::RPC::Client }) { if (eval { require JSON::RPC::Client }) {
...@@ -149,8 +152,12 @@ sub fault { $_[0]->is_error } ...@@ -149,8 +152,12 @@ sub fault { $_[0]->is_error }
1; 1;
package QA::RPC::UserAgent; package QA::RPC::UserAgent;
use 5.14.0;
use strict; use strict;
use base qw(LWP::UserAgent); use warnings;
use parent qw(LWP::UserAgent);
######################################## ########################################
# Consistency with XMLRPC::Lite's ->ua # # Consistency with XMLRPC::Lite's ->ua #
...@@ -172,3 +179,5 @@ sub http_response { ...@@ -172,3 +179,5 @@ sub http_response {
if (@_) { $self->{'_http_response'} = shift; return $self } if (@_) { $self->{'_http_response'} = shift; return $self }
return $self->{'_http_response'}; return $self->{'_http_response'};
} }
1;
...@@ -16,11 +16,9 @@ use warnings; ...@@ -16,11 +16,9 @@ use warnings;
use FindBin qw($RealBin); use FindBin qw($RealBin);
use lib "$RealBin/../../../lib", "$RealBin/../../../../local/lib/perl5"; use lib "$RealBin/../../../lib", "$RealBin/../../../../local/lib/perl5";
use base qw(QA::RPC XMLRPC::Lite); use parent qw(QA::RPC XMLRPC::Lite);
use constant TYPE => 'XML-RPC'; use constant TYPE => 'XML-RPC';
use constant DATETIME_REGEX => qr/^\d{8}T\d\d:\d\d:\d\d$/; use constant DATETIME_REGEX => qr/^\d{8}T\d\d:\d\d:\d\d$/;
1; 1;
__END__
...@@ -16,7 +16,8 @@ use warnings; ...@@ -16,7 +16,8 @@ use warnings;
use FindBin qw($RealBin); use FindBin qw($RealBin);
use lib "$RealBin/../../lib", "$RealBin/../../../local/lib/perl5"; use lib "$RealBin/../../lib", "$RealBin/../../../local/lib/perl5";
use base qw(Exporter); use parent qw(Exporter);
our @EXPORT_OK = qw( our @EXPORT_OK = qw(
PRIVATE_BUG_USER PRIVATE_BUG_USER
STANDARD_BUG_TESTS STANDARD_BUG_TESTS
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment