Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
bugzilla
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
etersoft
bugzilla
Commits
7d90eaa8
Commit
7d90eaa8
authored
Mar 02, 2011
by
Max Kanat-Alexander
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Bug 617641: Using any of the _realname columns in Search.pm all by themselves
wasn't working properly. r=mkanat, a=mkanat (module owner)
parent
ef54a40d
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
15 additions
and
2 deletions
+15
-2
Search.pm
Bugzilla/Search.pm
+2
-0
FieldTestNormal.pm
xt/lib/Bugzilla/Test/Search/FieldTestNormal.pm
+13
-2
No files found.
Bugzilla/Search.pm
View file @
7d90eaa8
...
...
@@ -945,6 +945,8 @@ sub _sql_limit {
sub
_column_join
{
my
(
$self
,
$field
)
=
@_
;
# The _realname fields require the same join as the username fields.
$field
=~
s/_realname$//
;
my
$join_info
=
COLUMN_JOINS
->
{
$field
};
if
(
$join_info
)
{
# Don't allow callers to modify the constant.
...
...
xt/lib/Bugzilla/Test/Search/FieldTestNormal.pm
View file @
7d90eaa8
...
...
@@ -58,6 +58,18 @@ sub name {
return
"$name (Normal Params)"
;
}
sub
search_columns
{
my
$self
=
shift
;
my
$field
=
$self
->
field
;
# For the assigned_to, qa_contact, and reporter fields, have the
# "Normal Params" test check that the _realname columns work
# all by themselves.
if
(
grep
(
$_
eq
$field
,
EMAIL_FIELDS
)
&&
$self
->
field_object
->
buglist
)
{
return
[
'bug_id'
,
"${field}_realname"
]
}
return
$self
->
SUPER::
search_columns
(
@_
);
}
sub
search_params
{
my
(
$self
)
=
@_
;
my
$field
=
$self
->
field
;
...
...
@@ -103,4 +115,4 @@ sub search_params {
return
{
$field
=>
$value
,
"${field}_type"
=>
$operator
};
}
1
;
\ No newline at end of file
1
;
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment