Commit 7d90eaa8 authored by Max Kanat-Alexander's avatar Max Kanat-Alexander

Bug 617641: Using any of the _realname columns in Search.pm all by themselves

wasn't working properly. r=mkanat, a=mkanat (module owner)
parent ef54a40d
......@@ -945,6 +945,8 @@ sub _sql_limit {
sub _column_join {
my ($self, $field) = @_;
# The _realname fields require the same join as the username fields.
$field =~ s/_realname$//;
my $join_info = COLUMN_JOINS->{$field};
if ($join_info) {
# Don't allow callers to modify the constant.
......
......@@ -58,6 +58,18 @@ sub name {
return "$name (Normal Params)";
}
sub search_columns {
my $self = shift;
my $field = $self->field;
# For the assigned_to, qa_contact, and reporter fields, have the
# "Normal Params" test check that the _realname columns work
# all by themselves.
if (grep($_ eq $field, EMAIL_FIELDS) && $self->field_object->buglist) {
return ['bug_id', "${field}_realname"]
}
return $self->SUPER::search_columns(@_);
}
sub search_params {
my ($self) = @_;
my $field = $self->field;
......@@ -103,4 +115,4 @@ sub search_params {
return { $field => $value, "${field}_type" => $operator };
}
1;
\ No newline at end of file
1;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment