Skip to content

bugzilla
bugzilla
Commit 808d96e1 authored by justdave%syndicomm.com's avatar justdave%syndicomm.com
Browse files
Options

[SECURITY] Bug 209376: If you know the email address of someone who has voted on…

[SECURITY] Bug 209376: If you know the email address of someone who has voted on a secure bug, you can access the summary of that bug even if you do not have sufficient permissions to view the bug itself. Patch by Gervase Markham <gerv@mozilla.org> r= justdave, bbaetz a= justdave
parent 92b479d9
Hide whitespace changes
Inline Side-by-side
Showing with 3 additions and 7 deletions
votes.cgi
View file @ 808d96e1
......@@ -128,12 +128,8 @@ sub show_user {
my $bug_id = $::FORM{'bug_id'} || "";
my $name = $::FORM{'user'} || Bugzilla->user->login;
my $who = DBname_to_id($name);
# After DBNameToIdAndCheck is templatised and prints a Content-Type,
# the above should revert to a call to that function, and this
# special error handling should go away.
$who || ThrowUserError("invalid_username", {name => $name});
my $who = DBNameToIdAndCheck($name);
my $userid = Bugzilla->user ? Bugzilla->user->id : 0;
my $canedit = 1 if (Bugzilla->user &&
$name eq Bugzilla->user->login);
......@@ -193,7 +189,7 @@ sub show_user {
# and they can see there are votes 'missing', but not on what bug
# they are. This seems a reasonable compromise; the alternative is
# to lie in the totals.
next if !CanSeeBug($id, $who);
next if !CanSeeBug($id, $userid);
push (@bugs, { id => $id,
summary => $summary,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment