<option> used when no flag is set is displayed as 'X' in Safari (#47)

After https://github.com/bugzilla/bugzilla/commit/7d0c10e71498f2909f466fc0ccda1890595bd3ff, the <option> used when no flag is set is displayed as 'X' in Safari. This is because WebKit displays the label when provided as per the latest HTML specification: - https://html.spec.whatwg.org/multipage/rendering.html#the-select-element-2 - https://html.spec.whatwg.org/multipage/forms.html#concept-option-label Chrome/Blink also display the label in standards mode, but not in quirks mode. The proposed fix is to use a whitespace as label instead of 'X'. This renders as empty in Firefox / Chrome and Safari and is still recognized as valid HTML as per https://validator.w3.org.

<option> used when no flag is set is displayed as 'X' in Safari (#47)
8103d9be · Chris Dumez · Dylan William Hardison · 08a36175 · 8103d9be
Commit 8103d9be authored Feb 13, 2018 by Chris Dumez Committed by Dylan William Hardison Feb 13, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

list.html.tmpl template/en/default/flag/list.html.tmpl +1 -1

No files found.
--- a/template/en/default/flag/list.html.tmpl
+++ b/template/en/default/flag/list.html.tmpl
@@ -125,7 +125,7 @@
          <option value="[% dontchange FILTER html %]">[% dontchange FILTER html %]</option>
        [% END %]
        [% IF !flag || (can_edit_flag && user.can_request_flag(type)) || flag.setter_id == user.id %]
-          <option value="X" label="X"></option>
+          <option value="X" label=" "></option>
        [% END %]
        [% IF type.is_active && can_edit_flag %]
          [% IF (type.is_requestable && user.can_request_flag(type)) || (flag && flag.status == "?") %]