fix for 49063: no sanity checking when setting duplicate. sanity checking

is done for the dup id field, but not for the originating bug id. now checks to see if the original bug id is valid as well, although i don't understand how this could get corrupted in the first place

fix for 49063: no sanity checking when setting duplicate. sanity checking
8fa450e9 · cyeh%bluemartini.com · e3b268ae · 8fa450e9
Commit 8fa450e9 authored Aug 30, 2000 by cyeh%bluemartini.com
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 0 deletions

process_bug.cgi process_bug.cgi +7 -0

No files found.
--- a/process_bug.cgi
+++ b/process_bug.cgi
@@ -528,6 +528,13 @@ SWITCH: for ($::FORM{'knob'}) {
                         "make sense to mark a bug as a duplicate of " .
                         "itself, does it?");
        }
+        my $checkid = trim($::FORM{'id'});
+        SendSQL("SELECT bug_id FROM bugs where bug_id = " .  SqlQuote($checkid));
+        $checkid = FetchOneColumn();
+        if (!$checkid) {
+            PuntTryAgain("The bug id $::FORM{'id'} is invalid. Please reload this bug ".
+                         "and try again.");
+        }
        AppendComment($num, $::FORM{'who'}, "*** Bug $::FORM{'id'} has been marked as a duplicate of this bug. ***");
        if ( Param('strictvaluechecks') ) {
          CheckFormFieldDefined(\%::FORM,'comment');