Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
bugzilla
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
etersoft
bugzilla
Commits
94929b9f
Commit
94929b9f
authored
Oct 14, 2013
by
Frédéric Buclin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Bug 340160: Speed up LogActivityEntry()
r=dkl a=glob
parent
5ab9af11
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
6 additions
and
5 deletions
+6
-5
Bug.pm
Bugzilla/Bug.pm
+6
-5
No files found.
Bugzilla/Bug.pm
View file @
94929b9f
...
...
@@ -3954,7 +3954,11 @@ sub get_activity {
# Update the bugs_activity table to reflect changes made in bugs.
sub
LogActivityEntry
{
my
(
$i
,
$col
,
$removed
,
$added
,
$whoid
,
$timestamp
,
$comment_id
)
=
@_
;
my
$dbh
=
Bugzilla
->
dbh
;
my
$sth
=
Bugzilla
->
dbh
->
prepare_cached
(
'INSERT INTO bugs_activity
(bug_id, who, bug_when, fieldid, removed, added, comment_id)
VALUES (?, ?, ?, ?, ?, ?, ?)'
);
# in the case of CCs, deps, and keywords, there's a possibility that someone
# might try to add or remove a lot of them at once, which might take more
# space than the activity table allows. We'll solve this by splitting it
...
...
@@ -3978,10 +3982,7 @@ sub LogActivityEntry {
trick_taint
(
$addstr
);
trick_taint
(
$removestr
);
my
$fieldid
=
get_field_id
(
$col
);
$dbh
->
do
(
"INSERT INTO bugs_activity
(bug_id, who, bug_when, fieldid, removed, added, comment_id)
VALUES (?, ?, ?, ?, ?, ?, ?)"
,
undef
,
(
$i
,
$whoid
,
$timestamp
,
$fieldid
,
$removestr
,
$addstr
,
$comment_id
));
$sth
->
execute
(
$i
,
$whoid
,
$timestamp
,
$fieldid
,
$removestr
,
$addstr
,
$comment_id
);
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment