Commit 972eed87 authored by bugreport%peshkin.net's avatar bugreport%peshkin.net

Bug 313547: When strict_isolation is set, don't allow inappropriate users on new bugs

Patch by Joel Peshkin <bugreport@peshkin.net> r=lpsolit, a=justdave
parent 1874993b
......@@ -257,6 +257,28 @@ if ($cgi->param('keywords') && UserInGroup("editbugs")) {
}
}
if (Param("strict_isolation")) {
my @blocked_users = ();
my %related_users = %ccids;
$related_users{$cgi->param('assigned_to')} = 1;
if (Param('useqacontact') && $cgi->param('qa_contact')) {
$related_users{$cgi->param('qa_contact')} = 1;
}
foreach my $pid (keys %related_users) {
my $related_user = Bugzilla::User->new($pid);
if (!$related_user->can_edit_product($product_id)) {
push (@blocked_users, $related_user->login);
}
}
if (scalar(@blocked_users)) {
ThrowUserError("invalid_user_group",
{'users' => \@blocked_users,
'new' => 1,
'product' => $product
});
}
}
# Check for valid dependency info.
foreach my $field ("dependson", "blocked") {
if (UserInGroup("editbugs") && $cgi->param($field)) {
......
......@@ -685,6 +685,8 @@
[%+ field_descs.product FILTER html %]
[% IF bug_id %]
for [% terms.bug %] '[% bug_id FILTER html %]'.
[% ELSIF new %]
and may not be included on a new [% terms.bug %].
[% ELSE %]
for at least one [% terms.bug %] being changed.
[% END %]
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment