Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
bugzilla
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
etersoft
bugzilla
Commits
9eec5129
Commit
9eec5129
authored
Dec 04, 2009
by
mkanat%bugzilla.org
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Bug 526162: Make the "private" argument to Bug.add_comment into "is_private", for consistency.
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=mkanat
parent
e6ada97a
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
12 additions
and
4 deletions
+12
-4
Bug.pm
Bugzilla/WebService/Bug.pm
+12
-4
No files found.
Bugzilla/WebService/Bug.pm
View file @
9eec5129
...
@@ -353,9 +353,13 @@ sub add_comment {
...
@@ -353,9 +353,13 @@ sub add_comment {
Bugzilla
->
user
->
can_edit_product
(
$bug
->
product_id
)
Bugzilla
->
user
->
can_edit_product
(
$bug
->
product_id
)
||
ThrowUserError
(
"product_edit_denied"
,
{
product
=>
$bug
->
product
});
||
ThrowUserError
(
"product_edit_denied"
,
{
product
=>
$bug
->
product
});
# Backwards-compatibility for versions before 3.6
if
(
defined
$params
->
{
private
})
{
$params
->
{
is_private
}
=
delete
$params
->
{
private
};
}
# Append comment
# Append comment
$bug
->
add_comment
(
$comment
,
{
isprivate
=>
$params
->
{
private
},
$bug
->
add_comment
(
$comment
,
{
isprivate
=>
$params
->
{
is_
private
},
work_time
=>
$params
->
{
work_time
}
});
work_time
=>
$params
->
{
work_time
}
});
# Capture the call to bug->update (which creates the new comment) in
# Capture the call to bug->update (which creates the new comment) in
...
@@ -1519,8 +1523,8 @@ comment to.
...
@@ -1519,8 +1523,8 @@ comment to.
If this is empty or all whitespace, an error will be thrown saying that
If this is empty or all whitespace, an error will be thrown saying that
you did not set the C<comment> parameter.
you did not set the C<comment> parameter.
=item C<
private> (boolean) - If set to true, the comment is private, otherwise
=item C<
is_private> (boolean) - If set to true, the comment is private,
it is assumed to be public.
otherwise
it is assumed to be public.
=item C<work_time> (double) - Adds this many hours to the "Hours Worked"
=item C<work_time> (double) - Adds this many hours to the "Hours Worked"
on the bug. If you are not in the time tracking group, this value will
on the bug. If you are not in the time tracking group, this value will
...
@@ -1567,6 +1571,10 @@ You tried to add a private comment, but don't have the necessary rights.
...
@@ -1567,6 +1571,10 @@ You tried to add a private comment, but don't have the necessary rights.
=item Modified to throw an error if you try to add a private comment
=item Modified to throw an error if you try to add a private comment
but can't, in Bugzilla B<3.4>.
but can't, in Bugzilla B<3.4>.
=item Before Bugzilla B<3.6>, the C<is_private> argument was called
C<private>, and you can still call it C<private> for backwards-compatibility
purposes if you wish.
=back
=back
=back
=back
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment