Commit a32a16ca authored by mkanat%bugzilla.org's avatar mkanat%bugzilla.org

Bug 364250: If a hook fails, no error is available for diagnosis

Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=colin, a=myk
parent bffa52bd
...@@ -44,8 +44,8 @@ sub process { ...@@ -44,8 +44,8 @@ sub process {
if (-e $extension.'/code/'.$name.'.pl') { if (-e $extension.'/code/'.$name.'.pl') {
Bugzilla->hook_args($args); Bugzilla->hook_args($args);
do($extension.'/code/'.$name.'.pl'); do($extension.'/code/'.$name.'.pl');
ThrowCodeError('extension_invalid', { ThrowCodeError('extension_invalid',
name => $name, extension => $extension }) if $@; { errstr => $@, name => $name, extension => $extension }) if $@;
} }
} }
......
...@@ -139,7 +139,7 @@ ...@@ -139,7 +139,7 @@
[% ELSIF error == "extension_invalid" %] [% ELSIF error == "extension_invalid" %]
An error occurred processing hook [% name FILTER html %] in An error occurred processing hook [% name FILTER html %] in
extension [% extension FILTER html %]. extension [% extension FILTER html %]: [% errstr FILTER html %]
[% ELSIF error == "extern_id_conflict" %] [% ELSIF error == "extern_id_conflict" %]
The external ID '[% extern_id FILTER html %]' already exists The external ID '[% extern_id FILTER html %]' already exists
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment