Bug 600495: Make searching using "chfieldto" actually work again, for finding

bugs that were also updated after the particular change that's being looked for. r=mkanat, a=mkanat (module owner)

Bug 600495: Make searching using "chfieldto" actually work again, for finding
a46cf131 · Max Kanat-Alexander · 9a93c623 · a46cf131
Commit a46cf131 authored Oct 02, 2010 by Max Kanat-Alexander
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 4 deletions

Search.pm Bugzilla/Search.pm +5 -4

No files found.
--- a/Bugzilla/Search.pm
+++ b/Bugzilla/Search.pm
@@ -1289,16 +1289,17 @@ sub _special_parse_chfield {

    my @charts;
    # It is always safe and useful to push delta_ts into the charts
-    # if there are any dates specified. It doesn't conflict with
+    # if there is a "from" date specified. It doesn't conflict with
    # searching [Bug creation], because a bug's delta_ts is set to
    # its creation_ts when it is created. So this just gives the
    # database an additional index to possibly choose.
+    #
+    # It's not safe to do it for "to" dates, though--"chfieldto" means
+    # "a field that changed before this date", and delta_ts could be either
+    # later or earlier than that.
    if ($date_from ne '') {
        push(@charts, ['delta_ts', 'greaterthaneq', $date_from]);
    }
-    if ($date_to ne '') {
-        push(@charts, ['delta_ts', 'lessthaneq', $date_to]);
-    }

    # Basically, we construct the chart like:
    #