Commit aa7b4750 authored by jake%acutex.net's avatar jake%acutex.net

Running a query using the Added Comment option was very slow (bug 57350).

Patch by Myk Melez <myk@mozilla.org> and Dave Miller <justdave@syndicomm.com> r= jake@acutex.net
parent aad3b8b5
...@@ -241,7 +241,7 @@ sub GenerateSQL { ...@@ -241,7 +241,7 @@ sub GenerateSQL {
push(@wherepart, "$table.bug_id = bugs.bug_id"); push(@wherepart, "$table.bug_id = bugs.bug_id");
my $ptable = "longdescnames_"; my $ptable = "longdescnames_";
push(@supptables, push(@supptables,
"LEFT JOIN profiles $ptable ON $table.who = $ptable.userid"); "INNER JOIN profiles $ptable ON $table.who = $ptable.userid");
push(@clist, "$ptable.login_name", $type, $email); push(@clist, "$ptable.login_name", $type, $email);
} }
if (@clist) { if (@clist) {
...@@ -745,7 +745,7 @@ sub GenerateSQL { ...@@ -745,7 +745,7 @@ sub GenerateSQL {
my $suppstring = "bugs"; my $suppstring = "bugs";
foreach my $str (@supptables) { foreach my $str (@supptables) {
if (!$suppseen{$str}) { if (!$suppseen{$str}) {
if ($str !~ /^LEFT JOIN/i) { if ($str !~ /^(LEFT|INNER) JOIN/i) {
$suppstring .= ","; $suppstring .= ",";
} }
$suppstring .= " $str"; $suppstring .= " $str";
......
...@@ -761,6 +761,7 @@ $table{longdescs} = ...@@ -761,6 +761,7 @@ $table{longdescs} =
thetext mediumtext, thetext mediumtext,
index(bug_id), index(bug_id),
index(who),
index(bug_when)'; index(bug_when)';
...@@ -2184,6 +2185,16 @@ if (-d 'shadow') { ...@@ -2184,6 +2185,16 @@ if (-d 'shadow') {
DropField("profiles", "emailnotification"); DropField("profiles", "emailnotification");
DropField("profiles", "newemailtech"); DropField("profiles", "newemailtech");
#
# 2001-06-06 justdave@syndicomm.com:
# There was no index on the 'who' column in the long descriptions table.
# This caused queries by who posted comments to take a LONG time.
# http://bugzilla.mozilla.org/show_bug.cgi?id=57350
if (!defined GetIndexDef('longdescs','who')) {
print "Adding index for who column in longdescs table...\n";
$dbh->do('ALTER TABLE longdescs ADD INDEX (who)');
}
# 2001-06-15 kiko@async.com.br - Change bug:version size to avoid # 2001-06-15 kiko@async.com.br - Change bug:version size to avoid
# truncates re http://bugzilla.mozilla.org/show_bug.cgi?id=9352 # truncates re http://bugzilla.mozilla.org/show_bug.cgi?id=9352
ChangeFieldType('bugs', 'version','varchar(64) not null'); ChangeFieldType('bugs', 'version','varchar(64) not null');
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment