Commit aadb30fd authored by mkanat%bugzilla.org's avatar mkanat%bugzilla.org

Bug 511796: Allow groups to bless themselves

Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit
parent 2594ac1a
...@@ -113,16 +113,19 @@ sub get_current_and_available { ...@@ -113,16 +113,19 @@ sub get_current_and_available {
if !grep($_->id == $group_option->id, @visible_to_me_current); if !grep($_->id == $group_option->id, @visible_to_me_current);
} }
# The group itself should never show up in the bless or push(@bless_from_available, $group_option)
# membership lists. if !grep($_->id == $group_option->id, @bless_from_current);
# The group itself should never show up in the membership lists,
# and should show up in only one of the bless lists (otherwise
# you can try to allow it to bless itself twice, leading to a
# database unique constraint error).
next if $group_option->id == $group->id; next if $group_option->id == $group->id;
push(@members_available, $group_option) push(@members_available, $group_option)
if !grep($_->id == $group_option->id, @members_current); if !grep($_->id == $group_option->id, @members_current);
push(@member_of_available, $group_option) push(@member_of_available, $group_option)
if !grep($_->id == $group_option->id, @member_of_current); if !grep($_->id == $group_option->id, @member_of_current);
push(@bless_from_available, $group_option)
if !grep($_->id == $group_option->id, @bless_from_current);
push(@bless_to_available, $group_option) push(@bless_to_available, $group_option)
if !grep($_->id == $group_option->id, @bless_to_current); if !grep($_->id == $group_option->id, @bless_to_current);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment