Commit ab5b48ea authored by kiko%async.com.br's avatar kiko%async.com.br

Fix for bug 252370: Provide edit link for attachment in comment. Adds an

[edit] link next to attachments in comment text, and removes the &action=view suffix which breaks things when pasting into a shell. r=bugreport, myk; a=myk.
parent c2719a4b
...@@ -968,10 +968,10 @@ sub GetAttachmentLink { ...@@ -968,10 +968,10 @@ sub GetAttachmentLink {
# Now that we know we've got all the information we're gonna get, let's # Now that we know we've got all the information we're gonna get, let's
# return the link (which is the whole reason we were called :) # return the link (which is the whole reason we were called :)
my ($title, $className) = @{$::attachlink{$attachid}}; my ($title, $className) = @{$::attachlink{$attachid}};
# $title will be undefined if the bug didn't exist in the database. # $title will be undefined if the attachment didn't exist in the database.
if (defined $title) { if (defined $title) {
my $linkval = "attachment.cgi?id=$attachid&action=view"; my $linkval = "attachment.cgi?id=$attachid";
return qq{<a href="$linkval" class="$className" title="$title">$link_text</a>}; return qq{<a href="$linkval" class="$className" title="$title">$link_text</a> [<a href="$linkval&amp;action=edit">edit</a>]};
} }
else { else {
return qq{$link_text}; return qq{$link_text};
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment