Bug 577053: When upgrading from a version earlier than 4.0,

change the logic on how we check to see if we need to populate the status_workflow table for an upgrading installation, because it was broken for upgrades from 2.18 and earlier.

Bug 577053: When upgrading from a version earlier than 4.0,
acaadbdf · Max Kanat-Alexander · 0de9839f · acaadbdf
Commit acaadbdf authored Jul 05, 2010 by Max Kanat-Alexander
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 4 deletions

DB.pm Bugzilla/Install/DB.pm +4 -4

No files found.
--- a/Bugzilla/Install/DB.pm
+++ b/Bugzilla/Install/DB.pm
@@ -2928,8 +2928,6 @@ sub _initialize_workflow_for_upgrade {
    my $old_params = shift;
    my $dbh = Bugzilla->dbh;

-    my $had_is_open = $dbh->bz_column_info('bug_status', 'is_open');
-
    $dbh->bz_add_column('bug_status', 'is_open',
                        {TYPE => 'BOOLEAN', NOTNULL => 1, DEFAULT => 'TRUE'});

@@ -2963,8 +2961,10 @@ sub _initialize_workflow_for_upgrade {
    }

    # We only populate the workflow here if we're upgrading from a version
-    # before 3.2.
-    return if $had_is_open;
+    # before 4.0 (which is where init_workflow was added).
+    my $new_exists = $dbh->selectrow_array(
+         'SELECT 1 FROM bug_status WHERE value = ?', undef, 'NEW');
+    return if !$new_exists;

    # Populate the status_workflow table. We do nothing if the table already
    # has entries. If all bug status transitions have been deleted, the