Commit b09ffb65 authored by Simon Green's avatar Simon Green Committed by David Lawrence

Bug 1151290: It is possible to tell if someone made a private comment on a bug…

Bug 1151290: It is possible to tell if someone made a private comment on a bug even if you are not an 'insider' r=dkl,a=glob
parent 74d7fca1
...@@ -2515,11 +2515,17 @@ sub _user_nonchanged { ...@@ -2515,11 +2515,17 @@ sub _user_nonchanged {
sub _long_desc_changedby { sub _long_desc_changedby {
my ($self, $args) = @_; my ($self, $args) = @_;
my ($chart_id, $joins, $value) = @$args{qw(chart_id joins value)}; my ($chart_id, $joins, $value) = @$args{qw(chart_id joins value)};
my $table = "longdescs_$chart_id"; my $table = "longdescs_$chart_id";
push(@$joins, { table => 'longdescs', as => $table }); push(@$joins, { table => 'longdescs', as => $table });
my $user_id = $self->_get_user_id($value); my $user_id = $self->_get_user_id($value);
$args->{term} = "$table.who = $user_id"; $args->{term} = "$table.who = $user_id";
# If the user is not part of the insiders group, they cannot see
# private comments
if (!$self->_user->is_insider) {
$args->{term} .= " AND $table.isprivate = 0";
}
} }
sub _long_desc_changedbefore_after { sub _long_desc_changedbefore_after {
...@@ -2527,7 +2533,7 @@ sub _long_desc_changedbefore_after { ...@@ -2527,7 +2533,7 @@ sub _long_desc_changedbefore_after {
my ($chart_id, $operator, $value, $joins) = my ($chart_id, $operator, $value, $joins) =
@$args{qw(chart_id operator value joins)}; @$args{qw(chart_id operator value joins)};
my $dbh = Bugzilla->dbh; my $dbh = Bugzilla->dbh;
my $sql_operator = ($operator =~ /before/) ? '<=' : '>='; my $sql_operator = ($operator =~ /before/) ? '<=' : '>=';
my $table = "longdescs_$chart_id"; my $table = "longdescs_$chart_id";
my $sql_date = $dbh->quote(SqlifyDate($value)); my $sql_date = $dbh->quote(SqlifyDate($value));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment