Skip to content

bugzilla
bugzilla
Commit b09ffb65 authored by Simon Green's avatar Simon Green Committed by David Lawrence
Browse files
Options

Bug 1151290: It is possible to tell if someone made a private comment on a bug…

Bug 1151290: It is possible to tell if someone made a private comment on a bug even if you are not an 'insider' r=dkl,a=glob
parent 74d7fca1
Show whitespace changes
Inline Side-by-side
Showing with 6 additions and 0 deletions
Bugzilla/Search.pm
View file @ b09ffb65
...@@ -2520,6 +2520,12 @@ sub _long_desc_changedby { ...@@ -2520,6 +2520,12 @@ sub _long_desc_changedby {
push(@$joins, { table => 'longdescs', as => $table }); push(@$joins, { table => 'longdescs', as => $table });
my $user_id = $self->_get_user_id($value); my $user_id = $self->_get_user_id($value);
$args->{term} = "$table.who = $user_id"; $args->{term} = "$table.who = $user_id";
# If the user is not part of the insiders group, they cannot see
# private comments
if (!$self->_user->is_insider) {
$args->{term} .= " AND $table.isprivate = 0";
}
} }
sub _long_desc_changedbefore_after { sub _long_desc_changedbefore_after {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment