Bug 745080: Voting extension causes database deadlocks

r=glob a=LpSolit

Bug 745080: Voting extension causes database deadlocks
b1779f28 · Frédéric Buclin · 3988beb8 · b1779f28
Commit b1779f28 authored Apr 17, 2012 by Frédéric Buclin
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

Extension.pm extensions/Voting/Extension.pm +4 -1

No files found.
--- a/extensions/Voting/Extension.pm
+++ b/extensions/Voting/Extension.pm
@@ -467,7 +467,10 @@ sub _page_user {
        }
    }

-    $dbh->do('DELETE FROM votes WHERE vote_count <= 0');
+    if ($canedit && $bug) {
+        $dbh->do('DELETE FROM votes WHERE vote_count = 0 AND who = ?',
+                 undef, $who->id);
+    }
    $dbh->bz_commit_transaction();

    $vars->{'canedit'} = $canedit;