Bug 768573: bug/field.html.tmpl overrides the 'hidden' variable, causing some…

Bug 768573: bug/field.html.tmpl overrides the 'hidden' variable, causing some field labels to be hidden by accident r=glob a=LpSolit

Bug 768573: bug/field.html.tmpl overrides the 'hidden' variable, causing some…
b3abb850 · Frédéric Buclin · d0b2bc68 · b3abb850
Commit b3abb850 authored Jul 31, 2012 by Frédéric Buclin
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 7 deletions

field.html.tmpl template/en/default/bug/field.html.tmpl +7 -7

No files found.
--- a/template/en/default/bug/field.html.tmpl
+++ b/template/en/default/bug/field.html.tmpl
@@ -21,14 +21,14 @@
  #                   with default field values being displayed on a page.
  #%]

-[% SET hidden = 0 %]
-[% IF bug AND !field.is_visible_on_bug(bug) %]
-  [% SET hidden = 1 %]
-[% END %]
-
 [% IF NOT no_tds %]
-  [% PROCESS "bug/field-label.html.tmpl" %]
-  <td class="field_value [% ' bz_hidden_field' IF hidden %]"
+  [% field_hidden = 0 %]
+  [% IF bug AND !field.is_visible_on_bug(bug) %]
+    [% field_hidden = 1 %]
+  [% END %]
+
+  [% INCLUDE "bug/field-label.html.tmpl" hidden = field_hidden %]
+  <td class="field_value [% ' bz_hidden_field' IF field_hidden %]"
      id="field_container_[% field.name FILTER html %]" 
      [% " colspan=\"$value_span\"" FILTER none IF value_span %]>
 [% END %]