Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
bugzilla
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
etersoft
bugzilla
Commits
b4c57eb5
Commit
b4c57eb5
authored
Sep 26, 2012
by
Byron Jones
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Bug 437212: Make page refreshing under Firefox update fields
r=LpSolit, a=LpSolit
parent
56189de6
Hide whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
75 additions
and
0 deletions
+75
-0
field.js
js/field.js
+48
-0
util.js
js/util.js
+21
-0
edit.html.tmpl
template/en/default/bug/edit.html.tmpl
+1
-0
field.html.tmpl
template/en/default/bug/field.html.tmpl
+1
-0
show-header.html.tmpl
template/en/default/bug/show-header.html.tmpl
+3
-0
list.html.tmpl
template/en/default/flag/list.html.tmpl
+1
-0
No files found.
js/field.js
View file @
b4c57eb5
...
...
@@ -927,3 +927,51 @@ function userDisabledTextOnChange(disabledtext) {
disable_mail
.
checked
=
true
;
}
}
/**
* Force the browser to honour the selected option when a page is refreshed,
* but only if the user hasn't explicitly selected a different option.
*/
function
initDirtyFieldTracking
()
{
// old IE versions don't provide the information we need to make this fix work
// however they aren't affected by this issue, so it's ok to ignore them
if
(
YAHOO
.
env
.
ua
.
ie
>
0
&&
YAHOO
.
env
.
ua
.
ie
<=
8
)
return
;
var
selects
=
document
.
getElementById
(
'changeform'
).
getElementsByTagName
(
'select'
);
for
(
var
i
=
0
,
l
=
selects
.
length
;
i
<
l
;
i
++
)
{
var
el
=
selects
[
i
];
var
el_dirty
=
document
.
getElementById
(
el
.
name
+
'_dirty'
);
if
(
!
el_dirty
)
continue
;
if
(
!
el_dirty
.
value
)
{
var
preSelected
=
bz_preselectedOptions
(
el
);
if
(
!
el
.
multiple
)
{
preSelected
.
selected
=
true
;
}
else
{
el
.
selectedIndex
=
-
1
;
for
(
var
j
=
0
,
m
=
preSelected
.
length
;
j
<
m
;
j
++
)
{
preSelected
[
j
].
selected
=
true
;
}
}
}
YAHOO
.
util
.
Event
.
on
(
el
,
"change"
,
function
(
e
)
{
var
el
=
e
.
target
||
e
.
srcElement
;
var
preSelected
=
bz_preselectedOptions
(
el
);
var
currentSelected
=
bz_selectedOptions
(
el
);
var
isDirty
=
false
;
if
(
!
el
.
multiple
)
{
isDirty
=
preSelected
.
index
!=
currentSelected
.
index
;
}
else
{
if
(
preSelected
.
length
!=
currentSelected
.
length
)
{
isDirty
=
true
;
}
else
{
for
(
var
i
=
0
,
l
=
preSelected
.
length
;
i
<
l
;
i
++
)
{
if
(
currentSelected
[
i
].
index
!=
preSelected
[
i
].
index
)
{
isDirty
=
true
;
break
;
}
}
}
}
document
.
getElementById
(
el
.
name
+
'_dirty'
).
value
=
isDirty
?
'1'
:
''
;
});
}
}
js/util.js
View file @
b4c57eb5
...
...
@@ -230,6 +230,27 @@ function bz_selectedOptions(aSelect) {
}
/**
* Returns all Option elements that have the "selected" attribute, as an array.
* Returns an empty array if nothing is selected.
*
* @param aSelect The select you want the pre-selected values of.
*/
function
bz_preselectedOptions
(
aSelect
)
{
var
options
=
aSelect
.
options
;
var
selected
=
new
Array
();
for
(
var
i
=
0
,
l
=
options
.
length
;
i
<
l
;
i
++
)
{
var
attributes
=
options
[
i
].
attributes
;
for
(
var
j
=
0
,
m
=
attributes
.
length
;
j
<
m
;
j
++
)
{
if
(
attributes
[
j
].
name
==
'selected'
)
{
if
(
!
aSelect
.
multiple
)
return
options
[
i
];
selected
.
push
(
options
[
i
]);
}
}
}
return
selected
;
}
/**
* Tells you where (what index) in a <select> a particular option is.
* Returns -1 if the value is not in the <select>
*
...
...
template/en/default/bug/edit.html.tmpl
View file @
b4c57eb5
...
...
@@ -1102,6 +1102,7 @@
<td>
[% IF bug.check_can_change_field(selname, 0, 1)
AND bug.choices.${selname}.size > 1 %]
<input type="hidden" id="[% selname %]_dirty">
<select id="[% selname %]" name="[% selname %]">
[% FOREACH x = bug.choices.${selname} %]
[% NEXT IF NOT x.is_active AND x.name != bug.${selname} %]
...
...
template/en/default/bug/field.html.tmpl
View file @
b4c57eb5
...
...
@@ -82,6 +82,7 @@
</script>
[% CASE [ constants.FIELD_TYPE_SINGLE_SELECT
constants.FIELD_TYPE_MULTI_SELECT ] %]
<input type="hidden" id="[% field.name FILTER html %]_dirty">
<select id="[% field.name FILTER html %]"
name="[% field.name FILTER html %]"
[% IF field.type == constants.FIELD_TYPE_MULTI_SELECT %]
...
...
template/en/default/bug/show-header.html.tmpl
View file @
b4c57eb5
...
...
@@ -37,6 +37,9 @@
history.replaceState(null, "[% unfiltered_title FILTER js %]", href);
}
}
YAHOO.util.Event.onDOMReady(function() {
initDirtyFieldTracking();
});
[% javascript FILTER none %]
[% END %]
[% END %]
...
...
template/en/default/flag/list.html.tmpl
View file @
b4c57eb5
...
...
@@ -107,6 +107,7 @@
[%- type.name FILTER html FILTER no_break -%]</label>
</td>
<td>
<input type="hidden" id="[% fid FILTER html %]_dirty">
<select id="[% fid FILTER html %]" name="[% fid FILTER html %]"
title="[% type.description FILTER html %]"
onchange="toggleRequesteeField(this);"
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment