Skip to content

bugzilla
bugzilla
Commit b66b079b authored by Koosha Khajeh Moogahi's avatar Koosha Khajeh Moogahi Committed by Frédéric Buclin
Browse files
Options

Bug 349015: importxml.pl throws a warning if there is no bug status defined

r/a=LpSolit
parent ff9b4b0d
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 3 deletions
importxml.pl
View file @ b66b079b
...@@ -841,7 +841,6 @@ sub process_bug { ...@@ -841,7 +841,6 @@ sub process_bug {
my $valid_status = check_field('bug_status', my $valid_status = check_field('bug_status',
scalar $bug_fields{'bug_status'}, scalar $bug_fields{'bug_status'},
undef, ERR_LEVEL ); undef, ERR_LEVEL );
my $is_open = is_open_state($bug_fields{'bug_status'});
my $status = $bug_fields{'bug_status'} || undef; my $status = $bug_fields{'bug_status'} || undef;
my $resolution = $bug_fields{'resolution'} || undef; my $resolution = $bug_fields{'resolution'} || undef;
...@@ -891,7 +890,7 @@ sub process_bug { ...@@ -891,7 +890,7 @@ sub process_bug {
if ($status) { if ($status) {
if($valid_status){ if($valid_status){
if($is_open){ if (is_open_state($status)) {
if ($resolution) { if ($resolution) {
$err .= "Resolution set on an open status.\n"; $err .= "Resolution set on an open status.\n";
$err .= " Dropping resolution $resolution\n"; $err .= " Dropping resolution $resolution\n";
...@@ -925,7 +924,7 @@ sub process_bug { ...@@ -925,7 +924,7 @@ sub process_bug {
} }
} }
} }
else{ # $is_open is false else {
if (!$resolution) { if (!$resolution) {
$err .= "Missing Resolution. Setting status to "; $err .= "Missing Resolution. Setting status to ";
if($everconfirmed){ if($everconfirmed){
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment