Bug 300403: New Charts errors out, creates new 'add' user, when Env auth method…

Bug 300403: New Charts errors out, creates new 'add' user, when Env auth method is used - Patch by A. Karl Kornel <karl@kornel.name> r=wurblzap a=justdave

Bug 300403: New Charts errors out, creates new 'add' user, when Env auth method…
b8c9e238 · lpsolit%gmail.com · b9f1149d · b8c9e238
Commit b8c9e238 authored Jul 26, 2005 by lpsolit%gmail.com
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 2 deletions

Env.pm Bugzilla/Auth/Login/WWW/Env.pm +6 -2

No files found.
--- a/Bugzilla/Auth/Login/WWW/Env.pm
+++ b/Bugzilla/Auth/Login/WWW/Env.pm
@@ -51,8 +51,12 @@ sub login {
    for ($env_id, $env_email, $env_realname) { $_ ||= '' };
    # make sure the email field contains only a valid email address
    my $emailregexp = Param("emailregexp");
-    $env_email =~ /($emailregexp)/;
-    $env_email = $1;
+    if ($env_email =~ /($emailregexp)/) {
+        $env_email = $1;
+    }
+    else {
+        return undef;
+    }
    # untaint the remaining values
    trick_taint($env_id);
    trick_taint($env_realname);