Commit b9022b0d authored by Frédéric Buclin's avatar Frédéric Buclin

Bug 373278: Add distinctive marking for security bugs in request.cgi

r=pyrzak a=LpSolit
parent 98e6bcc7
...@@ -113,7 +113,7 @@ sub queue { ...@@ -113,7 +113,7 @@ sub queue {
products.name, components.name, products.name, components.name,
flags.attach_id, attachments.description, flags.attach_id, attachments.description,
requesters.realname, requesters.login_name, requesters.realname, requesters.login_name,
requestees.realname, requestees.login_name, requestees.realname, requestees.login_name, COUNT(privs.group_id),
" . $dbh->sql_date_format('flags.modification_date', '%Y.%m.%d %H:%i') . " . $dbh->sql_date_format('flags.modification_date', '%Y.%m.%d %H:%i') .
# Use the flags and flagtypes tables for information about the flags, # Use the flags and flagtypes tables for information about the flags,
# the bugs and attachments tables for target info, the profiles tables # the bugs and attachments tables for target info, the profiles tables
...@@ -141,6 +141,8 @@ sub queue { ...@@ -141,6 +141,8 @@ sub queue {
ON bgmap.bug_id = bugs.bug_id ON bgmap.bug_id = bugs.bug_id
AND bgmap.group_id NOT IN (" . AND bgmap.group_id NOT IN (" .
$user->groups_as_string . ") $user->groups_as_string . ")
LEFT JOIN bug_group_map AS privs
ON privs.bug_id = bugs.bug_id
LEFT JOIN cc AS ccmap LEFT JOIN cc AS ccmap
ON ccmap.who = $userid ON ccmap.who = $userid
AND ccmap.bug_id = bugs.bug_id AND ccmap.bug_id = bugs.bug_id
...@@ -292,7 +294,8 @@ sub queue { ...@@ -292,7 +294,8 @@ sub queue {
'attach_summary' => $data[8] , 'attach_summary' => $data[8] ,
'requester' => ($data[9] ? "$data[9] <$data[10]>" : $data[10]) , 'requester' => ($data[9] ? "$data[9] <$data[10]>" : $data[10]) ,
'requestee' => ($data[11] ? "$data[11] <$data[12]>" : $data[12]) , 'requestee' => ($data[11] ? "$data[11] <$data[12]>" : $data[12]) ,
'created' => $data[13] 'restricted' => $data[13] ? 1 : 0,
'created' => $data[14]
}; };
push(@requests, $request); push(@requests, $request);
} }
......
...@@ -59,14 +59,14 @@ table.bz_buglist td, table.bz_buglist th { ...@@ -59,14 +59,14 @@ table.bz_buglist td, table.bz_buglist th {
/* we use a first-child class and not the pseudo-class because IE /* we use a first-child class and not the pseudo-class because IE
* doesn't support it :-( */ * doesn't support it :-( */
tr.bz_secure td.first-child { tr.bz_secure td.first-child, a.bz_secure {
background-image: url("../../images/padlock.png"); background-image: url("../../images/padlock.png");
background-position: center left; background-position: center left;
background-repeat: no-repeat; background-repeat: no-repeat;
background-color: inherit; background-color: inherit;
} }
th.first-child, td.first-child { th.first-child, td.first-child, a.bz_secure {
padding-left: 20px; padding-left: 20px;
} }
......
...@@ -31,6 +31,7 @@ ...@@ -31,6 +31,7 @@
" "
onload="var f = document.request_form; selectProduct(f.product, f.component, null, null, 'Any');" onload="var f = document.request_form; selectProduct(f.product, f.component, null, null, 'Any');"
javascript_urls=["js/productform.js"] javascript_urls=["js/productform.js"]
style_urls = ['skins/standard/buglist.css']
%] %]
<script type="text/javascript"> <script type="text/javascript">
...@@ -214,7 +215,8 @@ to some group are shown by default. ...@@ -214,7 +215,8 @@ to some group are shown by default.
[% END %] [% END %]
[% BLOCK display_bug %] [% BLOCK display_bug %]
<a href="show_bug.cgi?id=[% request.bug_id %]"> <a href="show_bug.cgi?id=[% request.bug_id %]"
[%- ' class="bz_secure"' IF request.restricted %]>
[% request.bug_id %]: [%+ request.bug_summary FILTER html %]</a> [% request.bug_id %]: [%+ request.bug_summary FILTER html %]</a>
[% END %] [% END %]
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment