Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
bugzilla
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
etersoft
bugzilla
Commits
c67b3b30
Commit
c67b3b30
authored
Sep 15, 2016
by
Simon Green
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Bug 399066 - Remove the 'cookiedomain' parameter
parent
a4601960
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
1 addition
and
33 deletions
+1
-33
CGI.pm
Bugzilla/CGI.pm
+1
-2
Advanced.pm
Bugzilla/Config/Advanced.pm
+0
-6
parameters.rst
docs/en/rst/administering/parameters.rst
+0
-13
advanced.html.tmpl
template/en/default/admin/params/advanced.html.tmpl
+0
-7
attachment.html.tmpl
template/en/default/admin/params/attachment.html.tmpl
+0
-5
No files found.
Bugzilla/CGI.pm
View file @
c67b3b30
...
...
@@ -451,8 +451,7 @@ sub send_cookie {
# Add the default path and the domain in.
my
$uri
=
URI
->
new
(
Bugzilla
->
params
->
{
urlbase
});
$paramhash
{
'-path'
}
=
$uri
->
path
;
$paramhash
{
'-domain'
}
=
Bugzilla
->
params
->
{
'cookiedomain'
}
if
Bugzilla
->
params
->
{
'cookiedomain'
};
$paramhash
{
'-domain'
}
=
$uri
->
host
if
$uri
->
host
;
push
(
@
{
$self
->
{
'Bugzilla_cookie_list'
}},
$self
->
cookie
(
%
paramhash
));
}
...
...
Bugzilla/Config/Advanced.pm
View file @
c67b3b30
...
...
@@ -17,12 +17,6 @@ our $sortkey = 1700;
use
constant
get_param_list
=>
(
{
name
=>
'cookiedomain'
,
type
=>
't'
,
default
=>
''
},
{
name
=>
'inbound_proxies'
,
type
=>
't'
,
default
=>
''
,
...
...
docs/en/rst/administering/parameters.rst
View file @
c67b3b30
...
...
@@ -239,10 +239,6 @@ attachment_base
:param:`urlbase` or :param:`sslbase`. That is, a different domain name that
resolves to this exact same Bugzilla installation.
Note that if you have set the :param:`cookiedomain` parameter, you should
set :param:`attachment_base` to use a domain that would not be matched by
:param:`cookiedomain`.
For added security, you can insert ``%bugid%`` into the URL, which will be
replaced with the ID of the current bug that the attachment is on, when you
access an attachment. This will limit attachments to accessing only other
...
...
@@ -825,15 +821,6 @@ confirmuniqueusermatch
Advanced
========
cookiedomain
Defines the domain for Bugzilla cookies. This is typically left blank.
If there are multiple hostnames that point to the same webserver, which
require the same cookie, then this parameter can be utilized. For
example, If your website is at
``https://bugzilla.example.com/``, setting this to
:paramval:`.example.com/` will also allow
``attachments.example.com/`` to access Bugzilla cookies.
inbound_proxies
When inbound traffic to Bugzilla goes through a proxy, Bugzilla thinks that
the IP address of the proxy is the IP address of every single user. If you
...
...
template/en/default/admin/params/advanced.html.tmpl
View file @
c67b3b30
...
...
@@ -41,13 +41,6 @@
[% END %]
[% param_descs = {
cookiedomain =>
"If your website is at 'www.foo.com', setting this to"
_ " '.foo.com' will also allow 'bar.foo.com' to access"
_ " Bugzilla cookies. This is useful if you have more than"
_ " one hostname pointing at the same web server, and you"
_ " want them to share the Bugzilla cookie.",
inbound_proxies =>
"When inbound traffic to Bugzilla goes through a proxy,"
_ " Bugzilla thinks that the IP address of every single"
...
...
template/en/default/admin/params/attachment.html.tmpl
View file @
c67b3b30
...
...
@@ -31,11 +31,6 @@
_ " that is not the same as <var>urlbase</var> or <var>sslbase</var>."
_ " That is, a different domain name that resolves to this exact"
_ " same Bugzilla installation.</p>"
_ "<p>Note that if you have set the"
_ " <a href=\"editparams.cgi?section=advanced#cookiedomain_desc\"><var>cookiedomain</var>"
_" parameter</a>, you should set <var>attachment_base</var> to use a"
_ " domain that would <em>not</em> be matched by"
_ " <var>cookiedomain</var>.</p>"
_ "<p>For added security, you can insert <var>%bugid%</var> into the URL,"
_ " which will be replaced with the ID of the current $terms.bug that"
_ " the attachment is on, when you access an attachment. This will limit"
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment