Bug 509794: Crash if setting a flag with Unicode characters in the name - Patch…

Bug 509794: Crash if setting a flag with Unicode characters in the name - Patch by FrÃ©dÃ©ric Buclin <LpSolit@gmail.com> r=bbaetz a=LpSolit

Bug 509794: Crash if setting a flag with Unicode characters in the name - Patch…
cd86036b · lpsolit%gmail.com · 3bc08bc5 · cd86036b
Commit cd86036b authored Sep 03, 2009 by lpsolit%gmail.com
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

email.txt.tmpl template/en/default/request/email.txt.tmpl +2 -1

No files found.
--- a/template/en/default/request/email.txt.tmpl
+++ b/template/en/default/request/email.txt.tmpl
@@ -77,7 +77,8 @@ Attachment [% attidsummary %]
 [%- FILTER bullet = wrap(80) %]

 [% USE Bugzilla %]
-[% IF Bugzilla.cgi.param("comment") && Bugzilla.cgi.param("comment").length > 0 %]
+[%-# .defined is necessary to avoid a taint issue in Perl < 5.10.1, see bug 509794. %]
+[% IF Bugzilla.cgi.param("comment").defined && Bugzilla.cgi.param("comment").length > 0 %]
 ------- Additional Comments from [% user.identity %]
 [%+ Bugzilla.cgi.param("comment") %]
 [% END %]