Bug 747110: Fix race condition in showdependencygraph.cgi triggering "use of…

Bug 747110: Fix race condition in showdependencygraph.cgi triggering "use of uninitialized value" warnings. r=LpSolit, a=LpSolit

Bug 747110: Fix race condition in showdependencygraph.cgi triggering "use of…
d550fa97 · Byron Jones · b66b079b · d550fa97
Commit d550fa97 authored Apr 23, 2012 by Byron Jones
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

showdependencygraph.cgi showdependencygraph.cgi +2 -1

No files found.
--- a/showdependencygraph.cgi
+++ b/showdependencygraph.cgi
@@ -296,7 +296,8 @@ foreach my $f (@files)
    # symlinks), this can't escape to delete anything it shouldn't
    # (unless someone moves the location of $webdotdir, of course)
    trick_taint($f);
-    if (file_mod_time($f) < $since) {
+    my $mtime = file_mod_time($f);
+    if ($mtime && $mtime < $since) {
        unlink $f;
    }
 }