Bug 376044: If we're running under mod_perl, use a refresh-style redirect

when coming back from colchange.cgi, because CGI.pm sometimes does not send headers properly under mod_perl when redirecting and sending cookies at the same time. r=justdave, a=mkanat

Bug 376044: If we're running under mod_perl, use a refresh-style redirect
d614dd98 · Max Kanat-Alexander · 1b3cfca0 · d614dd98
Commit d614dd98 authored May 19, 2010 by Max Kanat-Alexander
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 4 deletions

colchange.cgi colchange.cgi +7 -4

No files found.
--- a/colchange.cgi
+++ b/colchange.cgi
@@ -142,10 +142,13 @@ if (defined $cgi->param('rememberedquery')) {
    $vars->{'redirect_url'} = "buglist.cgi?".$params->query_string();


-    # If we're running on Microsoft IIS, using cgi->redirect discards
-    # the Set-Cookie lines -- workaround is to use the old-fashioned 
-    # redirection mechanism. See bug 214466 for details.
-    if ($ENV{'SERVER_SOFTWARE'} =~ /Microsoft-IIS/
+    # If we're running on Microsoft IIS, $cgi->redirect discards
+    # the Set-Cookie lines. In mod_perl, $cgi->redirect with cookies
+    # causes the page to be rendered as text/plain.
+    # Workaround is to use the old-fashioned  redirection mechanism. 
+    # See bug 214466 and bug 376044 for details.
+    if ($ENV{'MOD_PERL'} 
+        || $ENV{'SERVER_SOFTWARE'} =~ /Microsoft-IIS/
        || $ENV{'SERVER_SOFTWARE'} =~ /Sun ONE Web/)
    {
      print $cgi->header(-type => "text/html",