Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
bugzilla
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
etersoft
bugzilla
Commits
d758e50a
Commit
d758e50a
authored
Feb 17, 2010
by
Reed Loden
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Bug 537887 - "The flag setter should be able to unset a flag even if not in the request group"
[r=LpSolit a=LpSolit]
parent
ed751860
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
3 deletions
+4
-3
Flag.pm
Bugzilla/Flag.pm
+2
-0
list.html.tmpl
template/en/default/flag/list.html.tmpl
+2
-3
No files found.
Bugzilla/Flag.pm
View file @
d758e50a
...
...
@@ -731,10 +731,12 @@ sub _check_setter {
# Make sure the user is authorized to modify flags, see bug 180879:
# - The flag exists and is unchanged.
# - The flag setter can unset flag.
# - Users in the request_group can clear pending requests and set flags
# and can rerequest set flags.
# - Users in the grant_group can set/clear flags, including "+" and "-".
unless
((
$status
eq
$self
->
{
_old_status
})
||
(
$status
eq
'X'
&&
$setter
->
id
==
Bugzilla
->
user
->
id
)
||
((
$status
eq
'X'
||
$status
eq
'?'
)
&&
$setter
->
can_request_flag
(
$self
->
type
))
||
$setter
->
can_set_flag
(
$self
->
type
))
...
...
template/en/default/flag/list.html.tmpl
View file @
d758e50a
...
...
@@ -66,7 +66,7 @@
onchange="toggleRequesteeField(this);"
class="flag_select">
[%# Only display statuses the user is allowed to set. %]
[% IF user.can_request_flag(type) %]
[% IF user.can_request_flag(type)
|| flag.setter_id == user.id
%]
<option value="X"></option>
[% END %]
[% IF type.is_active %]
...
...
@@ -210,4 +210,4 @@
</td>
[% END %]
</tr>
[% END %]
\ No newline at end of file
[% END %]
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment