Bug 547311: Remove the "align" attribute from <th>

skins/standard/global.css

@@ -549,3 +549,7 @@ input.required, select.required, span.required_explanation {
     border: 2px solid #B70000;
     background-color: #FFEBEB;
 }
+
+form th {
+    text-align: right;
+}

template/en/default/account/auth/login.html.tmpl

@@ -29,14 +29,14 @@
 [%- IF Bugzilla.cgi.param("data") %] enctype="multipart/form-data"[% END %]>
   <table>
     <tr>
-      <th align="right"><label for="Bugzilla_login">Login:</label></th>
+      <th><label for="Bugzilla_login">Login:</label></th>
       <td>
         <input size="35" id="Bugzilla_login" name="Bugzilla_login">
         [% Param('emailsuffix') FILTER html %]
       </td>
     </tr>
     <tr>
-      <th align="right"><label for="Bugzilla_password">Password:</label></th>
+      <th><label for="Bugzilla_password">Password:</label></th>
       <td>
         <input type="password" size="35" id="Bugzilla_password" name="Bugzilla_password">
       </td>

template/en/default/account/email/confirm-new.html.tmpl

@@ -28,26 +28,26 @@
   <input type="hidden" name="a" value="confirm_new_account">
   <table>
     <tr>
-      <th align="right">Email Address:</th>
+      <th>Email Address:</th>
       <td>[% email FILTER html %]</td>
     </tr>
     <tr>
-      <th align="right"><small><i>(OPTIONAL)</i></small> <label for="realname">Real Name</label>:</th>
+      <th><small><i>(OPTIONAL)</i></small> <label for="realname">Real Name</label>:</th>
       <td><input type="text" id="realname" name="realname" value=""></td>
     </tr>
     <tr>
-      <th align="right"><label for="passwd1">Type your password</label>:</th>
+      <th><label for="passwd1">Type your password</label>:</th>
       <td>
         <input type="password" id="passwd1" name="passwd1" value="">
         (minimum [% constants.USER_PASSWORD_MIN_LENGTH FILTER none %] characters)
       </td>
     </tr>
     <tr>
-      <th align="right"><label for="passwd2">Confirm your password</label>:</th>
+      <th><label for="passwd2">Confirm your password</label>:</th>
       <td><input type="password" id="passwd2" name="passwd2" value=""></td>
     </tr>
     <tr>
-      <th align="right">&nbsp;</th>
+      <th>&nbsp;</th>
       <td><input type="submit" id="confirm" value="Create"></td>
     </tr>
   </table>

template/en/default/account/email/confirm.html.tmpl

@@ -22,11 +22,11 @@
   <input type="hidden" name="a" value="chgem">
   <table>
     <tr>
-      <th align="right">Password:</th>
+      <th>Password:</th>
       <td><input type="password" name="password" size="36"></td>
     </tr>
     <tr>
-      <th align="right">&nbsp;</th>
+      <th>&nbsp;</th>
       <td><input type="submit" id="confirm" value="Submit"></td>
     </tr>
   </table>

template/en/default/account/password/set-forgotten-password.html.tmpl

@@ -18,7 +18,7 @@
   <input type="hidden" name="a" value="chgpw">
   <table>
     <tr>
-      <th align="right">New Password:</th>
+      <th>New Password:</th>
       <td>
         <input type="password" name="password">
         (minimum [% constants.USER_PASSWORD_MIN_LENGTH FILTER none %] characters)
@@ -26,14 +26,14 @@
     </tr>
     
     <tr>
-      <th align="right">New Password Again:</th>
+      <th>New Password Again:</th>
       <td>
         <input type="password" name="matchpassword">
       </td>
     </tr>
     
     <tr>
-      <th align="right">&nbsp;</th>
+      <th>&nbsp;</th>
       <td>
         <input type="submit" id="update" value="Submit">
       </td>

template/en/default/account/prefs/account.html.tmpl

@@ -19,7 +19,7 @@
     </td>
   </tr>
   <tr>
-    <th align="right">Password:</th>
+    <th>Password:</th>
     <td>
       <input type="hidden" name="old_login" value="[% user.login FILTER html %]">
       <input type="password" name="old_password">
@@ -30,14 +30,14 @@
   </tr>
   [% IF user.authorizer.can_change_password %]
     <tr>
-      <th align="right">New password:</th>
+      <th>New password:</th>
       <td>
         <input type="password" name="new_password1">
       </td>
     </tr>              
 
     <tr>
-      <th align="right">Confirm new password:</th>
+      <th>Confirm new password:</th>
       <td>
         <input type="password" name="new_password2">
       </td>
@@ -45,7 +45,7 @@
   [% END %]
 
   <tr>
-    <th align="right">Your real name (optional, but encouraged):</th>
+    <th>Your real name (optional, but encouraged):</th>
     <td>
       <input size="35" name="realname" value="[% realname FILTER html %]">
     </td>
@@ -55,26 +55,26 @@
     [% IF login_change_date %]
       [% IF new_login_name %]
         <tr>
-          <th align="right">Pending email address:</th>
+          <th>Pending email address:</th>
           <td>[% new_login_name FILTER html %]</td>
         </tr>
         <tr>
-          <th align="right">Change request expires:</th>
+          <th>Change request expires:</th>
           <td>[% login_change_date FILTER time %]</td>
         </tr>
       [% ELSE %]
         <tr>
-          <th align="right">Confirmed email address:</th>
+          <th>Confirmed email address:</th>
           <td>[% user.login FILTER html %]</td>
         </tr>
         <tr>
-          <th align="right">Completion date:</th>
+          <th>Completion date:</th>
           <td>[% login_change_date FILTER time %]</td>
         </tr>
       [% END %]
     [% ELSE %]
       <tr>
-        <th align="right">New email address:</th>
+        <th>New email address:</th>
         <td>
           <input size="35" name="new_login_name">
         </td>

template/en/default/admin/classifications/edit-common.html.tmpl

@@ -11,12 +11,12 @@
   #%]
 
 <tr>
-  <th align="right">Classification:</th>
+  <th>Classification:</th>
   <td><input size=64 maxlength=64 name="classification" 
              value="[% classification.name FILTER html %]"></td>
 </tr>
 <tr>
-  <th align="right">Description:</th>
+  <th>Description:</th>
   <td>
     [% INCLUDE global/textarea.html.tmpl
       name           = 'description'
@@ -27,7 +27,7 @@
   </td>
 </tr>
 <tr>
-  <th align="right"><label for="sortkey">Sortkey:</label></th>
+  <th><label for="sortkey">Sortkey:</label></th>
   <td><input id="sortkey" size="20" maxlength="20" name="sortkey"
              value="[%- classification.sortkey FILTER html %]"></td>
 </tr>

template/en/default/admin/classifications/edit.html.tmpl

@@ -16,7 +16,7 @@
     [% PROCESS "admin/classifications/edit-common.html.tmpl" %]
 
     <tr valign=top>
-      <th align="right">
+      <th>
         <a href="editproducts.cgi?classification=[% classification.name FILTER uri %]">
         Edit Products</a>:
       </th>
@@ -25,7 +25,7 @@
           <table>
             [% FOREACH product = classification.products %]
               <tr>
-                <th align=right valign=top>[% product.name FILTER html %]</th>
+                <th valign=top>[% product.name FILTER html %]</th>
                 <td valign=top>
                   [% IF product.description %]
                     [% product.description FILTER html_light %]

template/en/default/admin/classifications/reclassify.html.tmpl

@@ -13,11 +13,11 @@
 <form method=post action="editclassifications.cgi">
   <table border=0 cellpadding=4 cellspacing=0>
     <tr>
-      <th align="right">Classification:</th>
+      <th>Classification:</th>
       <td valign="top" colspan=3>[% classification.name FILTER html %]</td>
 
     </tr><tr>
-      <th align="right">Description:</th>
+      <th>Description:</th>
       <td valign="top" colspan=3>
         [% IF classification.description %]
           [% classification.description FILTER html_light %]
@@ -27,11 +27,11 @@
       </td>
 
     </tr><tr>
-      <th align="right">Sortkey:</th>
+      <th>Sortkey:</th>
       <td valign="top" colspan=3>[% classification.sortkey FILTER html %]</td>
 
     </tr><tr>
-      <th align="right">Products:</th>
+      <th>Products:</th>
       <td valign="top">Other Classifications</td>
       <td></td>
       <td valign="top">This Classification</td>

template/en/default/admin/classifications/select.html.tmpl

@@ -12,11 +12,11 @@
 
 <table border=1 cellpadding=4 cellspacing=0>
   <tr bgcolor="#6666ff">
-    <th align="left">Edit Classification ...</th>
-    <th align="left">Description</th>
-    <th align="left">Sortkey</th>
-    <th align="left">Products</th>
-    <th align="left">Action</th>
+    <th>Edit Classification ...</th>
+    <th>Description</th>
+    <th>Sortkey</th>
+    <th>Products</th>
+    <th>Action</th>
   </tr>
 
   [% FOREACH cl = classifications %]

template/en/default/admin/custom_fields/edit-common.html.tmpl

@@ -78,7 +78,7 @@
              value="[% field.sortkey FILTER html %]">
     </td>
 
-    <th align="right"><label for="is_mandatory">Is mandatory:</label></th>
+    <th><label for="is_mandatory">Is mandatory:</label></th>
     <td>
       <input type="checkbox" id="is_mandatory" name="is_mandatory" value="1"
              [%- ' checked="checked"' IF field.is_mandatory %]>

template/en/default/admin/fieldvalues/create.html.tmpl

@@ -25,19 +25,19 @@
 <form method="post" action="editvalues.cgi">
   <table border="0" cellpadding="4" cellspacing="0">
     <tr>
-      <th align="right"><label for="value">Value:</label></th>
+      <th><label for="value">Value:</label></th>
       <td>
         <input id="value" name="value" size="30"
                maxlength="[% constants.MAX_FIELD_VALUE_SIZE FILTER none %]">
       </td>
     </tr>
     <tr>
-      <th align="right"><label for="sortkey">Sortkey:</label></th>
+      <th><label for="sortkey">Sortkey:</label></th>
       <td><input id="sortkey" name="sortkey" size="6" maxlength="6"></td>
     </tr>
     [% IF field.name == "bug_status" %]
       <tr>
-        <th align="right"><label for="is_open">Status Type:</label></th>
+        <th><label for="is_open">Status Type:</label></th>
         <td>
           <input type="radio" id="open_status" name="is_open" value="1" 
                  checked="checked">
@@ -56,7 +56,7 @@
     [% END %]
     [% IF field.value_field %]
       <tr>
-        <th align="right">
+        <th>
           <label for="visibility_value_id">Only appears when 
            [%+ field.value_field.description FILTER html %] is set to:
           </label>

template/en/default/admin/fieldvalues/edit.html.tmpl

@@ -39,19 +39,19 @@
       </td>
     </tr>
     <tr>
-      <th align="right"><label for="sortkey">Sortkey:</label></th>
+      <th><label for="sortkey">Sortkey:</label></th>
       <td><input id="sortkey" size="6" maxlength="6" name="sortkey" 
                  value="[%- value.sortkey FILTER html %]"></td>
     </tr>
     [% IF field.name == "bug_status" %]
       <tr>
-        <th align="right"><label for="is_open">Status Type:</label></th>
+        <th><label for="is_open">Status Type:</label></th>
         <td>[% IF value.is_open %]Open[% ELSE %]Closed[% END %]</td>
       </tr>
     [% END %]
     [% IF field.value_field %]
       <tr>
-        <th align="right">
+        <th>
           <label for="visibility_value_id">Only appears when
            [%+ field.value_field.description FILTER html %] is set to:
           </label>
@@ -76,7 +76,7 @@
       </tr>
     [% END %]
     <tr>
-      <th align="right"><label for="is_active">Enabled for [% terms.bugs %]:</label></th>
+      <th><label for="is_active">Enabled for [% terms.bugs %]:</label></th>
       <td><input id="is_active" name="is_active" type="checkbox" value="1" 
            [%+ 'checked="checked"' IF value.is_active %]
            [%+ 'disabled="disabled"' IF value.is_default OR value.is_static %]>

template/en/default/admin/keywords/create.html.tmpl

@@ -18,11 +18,11 @@
 <form method="post" action="editkeywords.cgi">
   <table border="0" cellpadding="4" cellspacing="0">
     <tr>
-      <th align="right">Name:</th>
+      <th>Name:</th>
       <td><input size="64" maxlength="64" name="name" value=""></td>
     </tr>
     <tr>
-      <th align="right">Description:</th>
+      <th>Description:</th>
       <td>
         [% INCLUDE global/textarea.html.tmpl
           name    = 'description'

template/en/default/admin/keywords/edit.html.tmpl

@@ -17,12 +17,12 @@
 <form method="post" action="editkeywords.cgi">
   <table border="0" cellpadding="4" cellspacing="0">
     <tr>
-      <th align="right">Name:</th>
+      <th>Name:</th>
       <td><input size="64" maxlength="64" name="name" 
                  value="[% keyword.name FILTER html %]"></td>
     </tr>
     <tr>
-      <th align="right">Description:</th>
+      <th>Description:</th>
       <td>
         [% INCLUDE global/textarea.html.tmpl
           name           = 'description'
@@ -34,7 +34,7 @@
       </td>
     </tr>
     <tr>
-      <th align="right">[% terms.Bugs %]:</th>
+      <th>[% terms.Bugs %]:</th>
       <td>
         [% IF keyword.bug_count > 0 %]
           <a href="buglist.cgi?keywords=[% keyword.name FILTER uri %]">

template/en/default/admin/milestones/create.html.tmpl

@@ -23,12 +23,12 @@
 <form name="f" method="post" action="editmilestones.cgi">
   <table border="0" cellpadding="4" cellspacing="0">
     <tr>
-      <th align="right"><label for="milestone">Milestone:</label></th>
+      <th><label for="milestone">Milestone:</label></th>
       <td><input id="milestone" size="64" maxlength="64" name="milestone"
                  value=""></td>
     </tr>
     <tr>
-      <th align="right"><label for="sortkey">Sortkey:</label></th>
+      <th><label for="sortkey">Sortkey:</label></th>
       <td><input id="sortkey" size="20" maxlength="20" name="sortkey"
                  value=""></td>
     </tr>

template/en/default/admin/products/confirm-delete.html.tmpl

@@ -110,7 +110,7 @@
         <table>
           [% FOREACH c = product.components %]
             <tr>
-              <th align="right">[% c.name FILTER html %]:</th>
+              <th>[% c.name FILTER html %]:</th>
               [%# descriptions are intentionally not filtered to allow html content %]
               <td>
                 [% IF c.description %]

template/en/default/admin/products/create.html.tmpl

@@ -35,13 +35,13 @@
     [% PROCESS "admin/products/edit-common.html.tmpl" %]
 
     <tr>
-      <th align="right">Version:</th>
+      <th>Version:</th>
       <td><input size="20" maxlength="64" name="version" 
                 value="[% version FILTER html %]">
       </td>
     </tr>
     <tr>
-      <th align="right">Create chart datasets for this product:</th>
+      <th>Create chart datasets for this product:</th>
       <td>
         <input type="checkbox" name="createseries" value="1" checked="checked">
       </td>

template/en/default/admin/products/edit-common.html.tmpl

@@ -14,32 +14,32 @@
 
 [% IF Param('useclassification') %]
   <tr>
-    <th align="right">Classification:</th>
+    <th>Classification:</th>
     <td><b>[% classification.name FILTER html %]</b></td>
   </tr>
 [% END %]
     
 <tr>
-  <th align="right">Product:</th>
+  <th>Product:</th>
   <td><input size="64" maxlength="64" name="product" 
              value="[% product.name FILTER html %]">
   </td>
 </tr>
 <tr>
-  <th align="right">Description:</th>
+  <th>Description:</th>
   <td><textarea rows="4" cols="64" wrap="virtual" name="description">
         [% product.description FILTER html %]</textarea>
   </td>
 </tr>
 
 <tr>
-  <th align="right">Open for [% terms.bug %] entry:</th>
+  <th>Open for [% terms.bug %] entry:</th>
   <td><input type="checkbox" name="is_active" value="1"
        [% ' checked="checked"' IF product.is_active %]>
   </td>
 </tr>
 <tr>
-  <th align="right">
+  <th>
     <label for="allows_unconfirmed">Enable the
       [%+ display_value('bug_status', 'UNCONFIRMED') FILTER html %] status
       in this product:</label>
@@ -51,7 +51,7 @@
 
 [% IF Param('usetargetmilestone') -%]
   <tr>
-    <th align="right">Default milestone:</th>
+    <th>Default milestone:</th>
     <td>
       [% IF product.milestones.size %]
         <select name="defaultmilestone">

template/en/default/admin/products/edit.html.tmpl

@@ -35,7 +35,7 @@
     [% PROCESS "admin/products/edit-common.html.tmpl" %]
 
     <tr>
-      <th align="right" valign="top">
+      <th valign="top">
         <a href="editcomponents.cgi?product=[% product.name FILTER uri %]">
         Edit components:
         </a>
@@ -59,7 +59,7 @@
       </td>
     </tr>
     <tr>
-      <th align="right" valign="top">
+      <th valign="top">
         <a href="editversions.cgi?product=[% product.name FILTER uri %]">Edit
 versions:</a>
       </th>
@@ -76,7 +76,7 @@ versions:</a>
     </tr>
     [% IF Param('usetargetmilestone') %]
       <tr>
-        <th align="right" valign="top">
+        <th valign="top">
           <a href="editmilestones.cgi?product=[% product.name FILTER uri %]">
           Edit milestones:</a>
         </th>
@@ -93,7 +93,7 @@ versions:</a>
       </tr>
     [% END %]
     <tr>
-      <th align="right" valign="top">
+      <th valign="top">
         <a href="editproducts.cgi?action=editgroupcontrols&product=
           [%- product.name FILTER uri %]">
           Edit Group Access Controls:
@@ -122,7 +122,7 @@ versions:</a>
       </td>
     </tr>
     <tr>
-      <th align="right">[% terms.Bugs %]:</th>
+      <th>[% terms.Bugs %]:</th>
       <td><a href="buglist.cgi?product=[% product.name FILTER uri %]">
             [% product.bug_count FILTER html %]</a></td>
     </tr>

template/en/default/admin/versions/create.html.tmpl

@@ -22,7 +22,7 @@
 <form method="post" action="editversions.cgi">
   <table border="0" cellpadding="4" cellspacing="0">
     <tr>
-      <th align="right"><label for="version">Version:</label></th>
+      <th><label for="version">Version:</label></th>
       <td><input id="version" size="64" maxlength="64" name="version"
                  value=""></td>
     </tr>

template/en/default/admin/workflow/comment.html.tmpl

@@ -48,7 +48,7 @@
   [% p = [{id => 0, name => "{Start}", is_open => 1}] %]
   [% FOREACH status = p.merge(statuses) %]
     <tr class="highlight">
-      <th align="right" class="[% status.is_open ? "open-status" : "closed-status" %]">
+      <th class="[% status.is_open ? "open-status" : "closed-status" %]">
         [% display_value("bug_status", status.name) FILTER html %]
       </th>
 

template/en/default/admin/workflow/edit.html.tmpl

@@ -53,7 +53,7 @@
   [% p = [{id => 0, name => "{Start}", is_open => 1}] %]
   [% FOREACH status = p.merge(statuses) %]
     <tr class="highlight">
-      <th align="right" class="[% status.is_open ? "open-status" : "closed-status" %]">
+      <th class="[% status.is_open ? "open-status" : "closed-status" %]">
         [% display_value("bug_status", status.name) FILTER html %]
       </th>
 

template/en/default/bug/dependency-graph.html.tmpl

@@ -51,7 +51,7 @@
 <form action="showdependencygraph.cgi" method="GET">
   <table>
     <tr>
-      <th align="left"><label for="id">[% terms.Bug %] numbers</label>:</th>
+      <th><label for="id">[% terms.Bug %] numbers</label>:</th>
       <td><input id="id" name="id" value="[% bug_id %]"></td>
       <td>
         <input type="checkbox" id="showsummary" name="showsummary" [% " checked" IF showsummary %]>
@@ -60,7 +60,7 @@
     </tr>
 
     <tr>
-      <th align="left"><label for="display">Display:</label></th>
+      <th><label for="display">Display:</label></th>
       <td colspan="2">
         <select id="display" name="display">
           <option value="tree"[% 'selected="selected"' IF (!display || display == "tree") %]>
@@ -72,7 +72,7 @@
     </tr>
 
     <tr>
-      <th align="left"><label for="rankdir">Orientation:</label></th>
+      <th><label for="rankdir">Orientation:</label></th>
       <td colspan="2">
         <select id="rankdir" name="rankdir">
           <option value="TB"[% " selected" IF rankdir == "TB" %]>Top to bottom</option>

template/en/default/global/choose-classification.html.tmpl

@@ -21,7 +21,7 @@
 
 <table>
   <tr>
-    <th align="right">
+    <th>
       <a href="[% target FILTER uri %]?classification=__all
             [% IF cloned_bug_id %]&amp;cloned_bug_id=[% cloned_bug_id FILTER uri %][% END -%] 
             [%- IF format %]&amp;format=[% format FILTER uri %][% END %]">
@@ -36,7 +36,7 @@
 
 [% FOREACH class = classifications %]
   <tr>
-    <th align="right">
+    <th>
       <a href="[% target FILTER uri %]?classification=[% class.name FILTER uri -%]
             [%- IF cloned_bug_id %]&amp;cloned_bug_id=[% cloned_bug_id FILTER uri %][% END -%] 
             [%- IF format %]&amp;format=[% format FILTER uri %][% END %]">

template/en/default/global/choose-product.html.tmpl

@@ -40,7 +40,7 @@
 
   [% FOREACH p = c.products %]
     <tr>
-      <th align="right" valign="top">
+      <th valign="top">
         <a href="[% target %]?product=[% p.name FILTER uri -%]
               [%- IF cloned_bug_id %]&amp;cloned_bug_id=[% cloned_bug_id FILTER uri %][% END -%] 
               [%- IF format %]&amp;format=[% format FILTER uri %][% END %]">

template/en/default/reports/keywords.html.tmpl

@@ -27,10 +27,10 @@
 
     <table border="1" cellpadding="4" cellspacing="0">
       <tr bgcolor="#6666FF">
-        <th align="left">Name</th>
-        <th align="left">Description</th>
-        <th align="left">Open [% terms.Bugs %]</th>
-        <th align="left">Total [% terms.Bugs %]</th>
+        <th>Name</th>
+        <th>Description</th>
+        <th>Open [% terms.Bugs %]</th>
+        <th>Total [% terms.Bugs %]</th>
       </tr>
   [% END %]
 

template/en/default/whine/mail.html.tmpl

@@ -47,10 +47,10 @@
 
     <table width="100%">
       <tr>
-        <th align="left">ID</th>
+        <th>ID</th>
         [% FOREACH col = query.columnlist %]
           [% NEXT IF col == 'bug_id' %]
-          <th align="left">[% field_descs.$col FILTER html %]</th>
+          <th>[% field_descs.$col FILTER html %]</th>
         [% END %]
       </tr>
 

template/en/default/whine/schedule.html.tmpl

@@ -72,7 +72,7 @@
 
 <table cellspacing="2" cellpadding="2" style="border: 1px solid;">
   <tr>
-    <th align="left">
+    <th>
       Event:
     </th>
     <td align="right" colspan="2">