Patch for bug 179351: improve variable scoping issues in order to fix a bug…

Patch for bug 179351: improve variable scoping issues in order to fix a bug causing oddly formatted dependency emails; patch by Teemu Mannermaa <wicked@etlicon.fi> revised slightly by justdave; r=joel; a=justdave.

Patch for bug 179351: improve variable scoping issues in order to fix a bug…
d9bcdba2 · jocuri%softhome.net · dffff7a2 · d9bcdba2
Commit d9bcdba2 authored Mar 20, 2004 by jocuri%softhome.net
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 4 deletions

BugMail.pm Bugzilla/BugMail.pm +3 -4

No files found.
--- a/Bugzilla/BugMail.pm
+++ b/Bugzilla/BugMail.pm
@@ -221,12 +221,11 @@ sub ProcessOneBug($) {

    my $difftext = "";
    my $diffheader = "";
-    my $diffpart = {};
    my @diffparts;
    my $lastwho = "";
    foreach my $ref (@diffs) {
        my ($who, $what, $when, $old, $new, $attachid, $fieldname) = (@$ref);
-        $diffpart = {};
+        my $diffpart = {};
        if ($who ne $lastwho) {
            $lastwho = $who;
            $diffheader = "\n$who" . Param('emailsuffix') . " changed:\n\n";
@@ -301,8 +300,8 @@ sub ProcessOneBug($) {
    $deptext = trim($deptext);

    if ($deptext) {
-        #$difftext = trim($difftext . "\n\n" . $deptext);
-        $diffpart->{'text'} = trim("\n\n" . $deptext);
+        my $diffpart = {};
+        $diffpart->{'text'} = "\n" . trim("\n\n" . $deptext);
        push(@diffparts, $diffpart);
    }