Commit dc4608b9 authored by mkanat%bugzilla.org's avatar mkanat%bugzilla.org

Bug 328628: When attachments have UTF-8 characters in their name, they will now…

Bug 328628: When attachments have UTF-8 characters in their name, they will now be downloaded with the correct name. Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=Wurblzap, a=mkanat
parent 2f2a2401
......@@ -52,6 +52,8 @@ use Bugzilla::Attachment::PatchReader;
use Bugzilla::Token;
use Bugzilla::Keyword;
use Encode qw(encode);
# For most scripts we don't make $cgi and $template global variables. But
# when preparing Bugzilla for mod_perl, this script used these
# variables in so many subroutines that it was easier to just
......@@ -318,6 +320,11 @@ sub view {
$filename =~ s/\\/\\\\/g; # escape backslashes
$filename =~ s/"/\\"/g; # escape quotes
# Avoid line wrapping done by Encode, which we don't need for HTTP
# headers. See discussion in bug 328628 for details.
local $Encode::Encoding{'MIME-Q'}->{'bpl'} = 10000;
$filename = encode('MIME-Q', $filename);
my $disposition = Bugzilla->params->{'allow_attachment_display'} ? 'inline' : 'attachment';
print $cgi->header(-type=>"$contenttype; name=\"$filename\"",
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment