Skip to content

bugzilla
bugzilla
Commit ec22b114 authored by jocuri%softhome.net's avatar jocuri%softhome.net
Browse files
Options

Patch for bug 247772: Improve SQL capitalization in collectstats; r=joel; a=justdave.

parent 8381f577
Hide whitespace changes
Inline Side-by-side
Showing with 4 additions and 4 deletions
collectstats.pl
View file @ ec22b114
...@@ -139,9 +139,9 @@ sub collect_stats { ...@@ -139,9 +139,9 @@ sub collect_stats {
foreach my $status ('NEW', 'ASSIGNED', 'REOPENED', 'UNCONFIRMED', 'RESOLVED', 'VERIFIED', 'CLOSED') { foreach my $status ('NEW', 'ASSIGNED', 'REOPENED', 'UNCONFIRMED', 'RESOLVED', 'VERIFIED', 'CLOSED') {
if( $product eq "-All-" ) { if( $product eq "-All-" ) {
SendSQL("select count(bug_status) from bugs where bug_status='$status'"); SendSQL("SELECT COUNT(bug_status) FROM bugs WHERE bug_status='$status'");
} else { } else {
SendSQL("select count(bug_status) from bugs where bug_status='$status' and product_id=$product_id"); SendSQL("SELECT COUNT(bug_status) FROM bugs WHERE bug_status='$status' AND product_id=$product_id");
} }
push @row, FetchOneColumn(); push @row, FetchOneColumn();
...@@ -149,9 +149,9 @@ sub collect_stats { ...@@ -149,9 +149,9 @@ sub collect_stats {
foreach my $resolution ('FIXED', 'INVALID', 'WONTFIX', 'LATER', 'REMIND', 'DUPLICATE', 'WORKSFORME', 'MOVED') { foreach my $resolution ('FIXED', 'INVALID', 'WONTFIX', 'LATER', 'REMIND', 'DUPLICATE', 'WORKSFORME', 'MOVED') {
if( $product eq "-All-" ) { if( $product eq "-All-" ) {
SendSQL("select count(resolution) from bugs where resolution='$resolution'"); SendSQL("SELECT COUNT(resolution) FROM bugs WHERE resolution='$resolution'");
} else { } else {
SendSQL("select count(resolution) from bugs where resolution='$resolution' and product_id=$product_id"); SendSQL("SELECT COUNT(resolution) FROM bugs WHERE resolution='$resolution' AND product_id=$product_id");
} }
push @row, FetchOneColumn(); push @row, FetchOneColumn();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment