Bug 528918: Bugzilla::Object->match() shouldn't call _check_field() when the…

Bug 528918: Bugzilla::Object->match() shouldn't call _check_field() when the field being passed can be trusted (deserialising the DB schema is slow) r=dkl a=LpSolit

Bug 528918: Bugzilla::Object->match() shouldn't call _check_field() when the…
ec2e4a09 · Frédéric Buclin · 38cbb6ac · ec2e4a09
Commit ec2e4a09 authored Feb 29, 2012 by Frédéric Buclin
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 2 deletions

Object.pm Bugzilla/Object.pm +5 -2

No files found.
--- a/Bugzilla/Object.pm
+++ b/Bugzilla/Object.pm
@@ -214,8 +214,11 @@ sub match {
            }            
            next;
        }
-        
-        $class->_check_field($field, 'match');
+
+        # It's always safe to use the field defined by classes as being
+        # their ID field. In particular, this means that new_from_list()
+        # is exempted from this check.
+        $class->_check_field($field, 'match') unless $field eq $class->ID_FIELD;

        if (ref $value eq 'ARRAY') {
            # IN () is invalid SQL, and if we have an empty list