Bug 103664 - Tests should "use strict;" and not contain any tabs. We should…

runtests.sh

 #!/bin/sh
 
-export VERBOSE=0
+export TEST_VERBOSE=0
 PART1='use Test::Harness qw(&runtests $verbose); $verbose='
 PART2='; runtests @ARGV;'
 for f in $*; do
   if [ $f == "--verbose" ] ; then
-    export VERBOSE=1
+    export TEST_VERBOSE=1
   fi
 done
 
-/usr/bonsaitools/bin/perl -e "${PART1}${VERBOSE}${PART2}" t/*.t
+/usr/bonsaitools/bin/perl -e "${PART1}${TEST_VERBOSE}${PART2}" t/*.t

t/001compile.t

+# -*- Mode: perl; indent-tabs-mode: nil -*-
 #
 # The contents of this file are subject to the Mozilla Public
 # License Version 1.1 (the "License"); you may not use this file
@@ -40,17 +41,15 @@ BEGIN { use Support::Files; }
 BEGIN { $tests = @Support::Files::testitems + 4; }
 BEGIN { use Test::More tests => $tests; }
 
-sub foo {
-$warnings = "foo"; #oy!
-}
+use strict;
 
 # First now we test the scripts                                                   
-@testitems = @Support::Files::testitems; 
+my @testitems = @Support::Files::testitems; 
+my %warnings;
+my $verbose = $::ENV{TEST_VERBOSE};
+my $perlapp = $^X;
 
-my $warnings;
-my $verbose = $::ENV{VERBOSE};
-$perlapp=$^X;
-foreach $file (@testitems) {
+foreach my $file (@testitems) {
         $file =~ s/\s.*$//; # nuke everything after the first space (#comment)
         next if (!$file); # skip null entries
         open (FILE,$file);
@@ -60,9 +59,9 @@ foreach $file (@testitems) {
         if ($bang =~ m/#!\S*perl\s+-.*T/) {
             $T = "T";
         }
-	$command = "$perlapp"." -c$T $file 2>&1";
-	$loginfo=`$command`;
-#	  print '@@'.$loginfo.'##';
+        my $command = "$perlapp"." -c$T $file 2>&1";
+        my $loginfo=`$command`;
+        #print '@@'.$loginfo.'##';
         if ($loginfo =~ /syntax ok$/im) {
                 $warnings{$_} = 1 foreach ($loginfo =~ /\((W.*?)\)/mg);
                 if ($1) {

t/002goodperl.t

+# -*- Mode: perl; indent-tabs-mode: nil -*-
 # 
 # The contents of this file are subject to the Mozilla Public
 # License Version 1.1 (the "License"); you may not use this file
@@ -40,12 +41,15 @@ BEGIN { use Support::Files; }
 BEGIN { $tests = @Support::Files::testitems * 2; }
 BEGIN { use Test::More tests => $tests; }
 
-@testitems = @Support::Files::testitems; # get the files to test.
+use strict;
 
-foreach $file (@testitems) {
+my @testitems = @Support::Files::testitems; # get the files to test.
+my $verbose = $::ENV{TEST_VERBOSE};
+
+foreach my $file (@testitems) {
         $file =~ s/\s.*$//; # nuke everything after the first space (#comment)
         next if (!$file); # skip null entries
-	$filecontent = `cat $file`;
+        my $filecontent = `cat $file`;
         if ($filecontent !~ /\/usr\/bonsaitools\/bin\/perl/) {
                 ok(1,"$file does not have a shebang");	
                 next;
@@ -59,10 +63,10 @@ foreach $file (@testitems) {
                 }
         }
 }
-foreach $file (@testitems) {
+foreach my $file (@testitems) {
         $file =~ s/\s.*$//; # nuke everything after the first space (#comment)
         next if (!$file); # skip null entries
-	$filecontent = `cat $file`;
+        my $filecontent = `cat $file`;
         if ($filecontent !~ /use strict/) {
                 ok(0,"$file DOES NOT use strict");
         } else {

t/003safesys.t

+# -*- Mode: perl; indent-tabs-mode: nil -*-
 # 
 # The contents of this file are subject to the Mozilla Public
 # License Version 1.1 (the "License"); you may not use this file
@@ -40,15 +41,18 @@ BEGIN { use Support::Files; }
 BEGIN { $tests = @Support::Files::testitems; }    
 BEGIN { use Test::More tests => $tests; }
 
-@testitems = @Support::Files::testitems; 
-my $verbose = $::ENV{VERBOSE};
-$perlapp=$^X;
-foreach $file (@testitems) {
+use strict;
+
+my @testitems = @Support::Files::testitems; 
+my $verbose = $::ENV{TEST_VERBOSE};
+my $perlapp = $^X;
+
+foreach my $file (@testitems) {
         $file =~ s/\s.*$//; # nuke everything after the first space (#comment)
         next if (!$file); # skip null entries
-	$command = "$perlapp -c -It/Support -MSystemexec $file 2>&1";
-	$loginfo=`$command`;
-	if ($loginfo =~ /arguments for Systemexec::system|exec/im) {
+        my $command = "$perlapp -c -It -MSupport::Systemexec $file 2>&1";
+        my $loginfo=`$command`;
+        if ($loginfo =~ /arguments for Support::Systemexec::(system|exec)/im) {
                 ok(0,"$file DOES NOT use proper system or exec calls");
                 if ($verbose) { print STDERR $loginfo; }
         } else {

t/004template.t

@@ -29,11 +29,12 @@ BEGIN { use Support::Templates; }
 BEGIN { $tests = @Support::Templates::testitems * 2; }
 BEGIN { use Test::More tests => $tests; }
 
+use strict;
 use Template;
 
 my @testitems = @Support::Templates::testitems;
 my $include_path = $Support::Templates::include_path;
-my $verbose = $::ENV{VERBOSE};
+my $verbose = $::ENV{TEST_VERBOSE};
 
 # Check to make sure all templates that are referenced in
 # Bugzilla exist in the proper place.

t/005no_tabs.t

@@ -21,7 +21,7 @@
 #
 
 #################
-#Bugzilla Test 4#
+#Bugzilla Test 5#
 #####no_tabs#####
 
 BEGIN { use lib "t/"; }
@@ -29,8 +29,10 @@ BEGIN { use Support::Files; }
 BEGIN { $tests = @Support::Files::testitems; }
 BEGIN { use Test::More tests => $tests; }
 
+use strict;
+
 my @testitems = @Support::Files::testitems;
-my $verbose = $::ENV{VERBOSE};
+my $verbose = $::ENV{TEST_VERBOSE};
 
 foreach my $file (@testitems) {
     open (FILE, "$file");

t/Support/Files.pm

+# -*- Mode: perl; indent-tabs-mode: nil -*-
 # 
 # The contents of this file are subject to the Mozilla Public
 # License Version 1.1 (the "License"); you may not use this file

t/Support/Systemexec.pm

-package Systemexec;
+# -*- Mode: perl; indent-tabs-mode: nil -*-
+
+package Support::Systemexec;
 require Exporter;
 @ISA = qw(Exporter);
 @EXPORT = qw(system exec);