Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
bugzilla
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
etersoft
bugzilla
Commits
f1099078
Commit
f1099078
authored
Jul 22, 2013
by
Byron Jones
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Bug 850986: don't allow setting a flag's requestee to a disabled account
r=dkl, a=justdave
parent
ca9d0d91
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
12 additions
and
2 deletions
+12
-2
Flag.pm
Bugzilla/Flag.pm
+6
-1
user-error.html.tmpl
template/en/default/global/user-error.html.tmpl
+6
-1
No files found.
Bugzilla/Flag.pm
View file @
f1099078
...
...
@@ -668,9 +668,14 @@ sub _check_requestee {
# is specifically requestable. For existing flags, if the requestee
# was set before the flag became specifically unrequestable, the
# user can either remove him or leave him alone.
ThrowUserError
(
'flag_requestee_disabled'
,
{
type
=>
$self
->
type
})
ThrowUserError
(
'flag_
type_
requestee_disabled'
,
{
type
=>
$self
->
type
})
if
!
$self
->
type
->
is_requesteeble
;
# You can't ask a disabled account, as they don't have the ability to
# set the flag.
ThrowUserError
(
'flag_requestee_disabled'
,
{
requestee
=>
$requestee
})
if
!
$requestee
->
is_enabled
;
# Make sure the requestee can see the bug.
# Note that can_see_bug() will query the DB, so if the bug
# is being added/removed from some groups and these changes
...
...
template/en/default/global/user-error.html.tmpl
View file @
f1099078
...
...
@@ -633,10 +633,15 @@
<br>Alternately, if your attachment is an image, you could convert
it to a compressible format like JPG or PNG and try again.
[% ELSIF error == "flag_requestee_disabled" %]
[% ELSIF error == "flag_
type_
requestee_disabled" %]
[% title = "Flag not Requestable from Specific Person" %]
You can't ask a specific person for <em>[% type.name FILTER html %]</em>.
[% ELSIF error == "flag_requestee_disabled" %]
[% title = "Flag Requestee Disabled" %]
You can't ask <em>[% requestee.identity FILTER html %]</em> because that
account is disabled.
[% ELSIF error == "flag_requestee_needs_privs" %]
[% title = "Flag Requestee Needs Privileges" %]
[% requestee.identity FILTER html %] does not have permission to set the
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment